Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

update scala-xml#237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
farmdawgnation merged 1 commit intodispatch:mainfromyanns:235_update_scala_xml
Feb 2, 2023
Merged

Conversation

@yanns
Copy link
Contributor

fix#235
lift-json also depends on scala-xml 1.2.
lift-json is not maintained anymore.
I propose to remove the module.

fixdispatch#235lift-json also depends on scala-xml 1.2.lift-json is not maintained anymore.I propose to remove the module.
@yanns
Copy link
ContributorAuthor

@farmdawgnation can you authorize the PR checks?

@farmdawgnation
Copy link
Member

farmdawgnation commentedJan 30, 2023 via email

Yeah. I’ll have a look today. On Jan 30, 2023, at 3:38 AM, Yann Simon ***@***.***> wrote:@farmdawgnation can you authorize the PR checks?—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

@farmdawgnation
Copy link
Member

PR checks are authorized. Will noodle on how I feel about actually pulling the plug on lift-json support but alas, I'm also one of the key maintainers over there and I'm not sure it's aged particularly well.

@farmdawgnation
Copy link
Member

Checks have all passed... give me a bit to think about the lift-json question.

yanns reacted with thumbs up emoji

Copy link
Member

@farmdawgnationfarmdawgnation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approved, though I think I'll have to consider this a major version bump.

@farmdawgnationfarmdawgnation merged commit658a1ba intodispatch:mainFeb 2, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@farmdawgnationfarmdawgnationfarmdawgnation approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update scala-xml dependency to version 2

2 participants

@yanns@farmdawgnation

[8]ページ先頭

©2009-2025 Movatter.jp