- Notifications
You must be signed in to change notification settings - Fork8.8k
UX: Use English as language label where appropriate#36762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+194 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ZogStriP approved these changesDec 17, 2025
Member
ZogStriP left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Weird we differentiate English US vs English UK but not Portuguese PT vs Portuguese BR
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Natalie Tay <natalie.tay@gmail.com>
3baf375 intomain 15 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR makes two changes:
"English (US)" is needlessly geo-specific. Given it is the default language, using "English" as the label is shorter and clearer. It still differentiates from "English (UK)" when choosing the interface language for users (or in admin UIs):
And the PR also strips
(UK)from the language switcher list when "English (UK)" is the only English variant enabled. This is a bit hacky, but it lets us have cleaner UX (especially for countries like Canada, Australia, where sites may opt foren_GBas their default) while keeping the necessary technical separation between English and English (UK) in admin and user preference screens.