Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DEV: Replace@ember/object/computed with native getters#36761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
megothss wants to merge5 commits intomain
base:main
Choose a base branch
Loading
fromdev/remove-computed-decorators-from-models

Conversation

@megothss
Copy link
Contributor

Refactor models to replace deprecated@ember/object/computed macros with@dependentKeyCompat and native class fields powered by@tracked. This aligns with modern Ember patterns, ensuring future compatibility and performance improvements.

Refactor models to replace deprecated `@ember/object/computed` macros with `@dependentKeyCompat` and native class fields powered by `@tracked`. This aligns with modern Ember patterns, ensuring future compatibility and performance improvements.
@megothssmegothss marked this pull request as draftDecember 17, 2025 22:36
Update `site.js` to use `isReadOnly` instead of `is_readonly`, aligning with standard camelCase conventions. Removed the legacy getter for `isReadOnly`, as it is no longer needed with `@tracked` properties. This simplifies code and adheres to modern Ember best practices.
Update `composer-body.js` to replace the key name `composer.sharedDraft`with `composer.creatingSharedDraft`, improving clarity and consistencywithin the `bindProperties` list. Ensures better readability and alignswith naming conventions across the component.
Ensure `AUTO_GROUPS.everyone` is passed as an array in the header API testto comply with expected `user.groups` formatting. This change improvestest stability and consistency with the `needs.user` API usage.
Update the `sharedDraft` key to `creatingSharedDraft` in `composer.js` forimproved clarity and consistency with the naming conventions used acrossthe codebase. This change ensures better readability and alignment withexisting patterns.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@megothss

[8]ページ先頭

©2009-2025 Movatter.jp