- Notifications
You must be signed in to change notification settings - Fork8.7k
DEV: Replace@ember/object/computed with native getters#36761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
megothss wants to merge5 commits intomainChoose a base branch fromdev/remove-computed-decorators-from-models
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Refactor models to replace deprecated `@ember/object/computed` macros with `@dependentKeyCompat` and native class fields powered by `@tracked`. This aligns with modern Ember patterns, ensuring future compatibility and performance improvements.
Update `site.js` to use `isReadOnly` instead of `is_readonly`, aligning with standard camelCase conventions. Removed the legacy getter for `isReadOnly`, as it is no longer needed with `@tracked` properties. This simplifies code and adheres to modern Ember best practices.
Update `composer-body.js` to replace the key name `composer.sharedDraft`with `composer.creatingSharedDraft`, improving clarity and consistencywithin the `bindProperties` list. Ensures better readability and alignswith naming conventions across the component.
Ensure `AUTO_GROUPS.everyone` is passed as an array in the header API testto comply with expected `user.groups` formatting. This change improvestest stability and consistency with the `needs.user` API usage.
Update the `sharedDraft` key to `creatingSharedDraft` in `composer.js` forimproved clarity and consistency with the naming conventions used acrossthe codebase. This change ensures better readability and alignment withexisting patterns.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor models to replace deprecated
@ember/object/computedmacros with@dependentKeyCompatand native class fields powered by@tracked. This aligns with modern Ember patterns, ensuring future compatibility and performance improvements.