Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DEV: Allow new instances to be set up directly with Discourse ID#36731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
pmusaraj wants to merge17 commits intomain
base:main
Choose a base branch
Loading
fromsetup-discourse-id-on-install

Conversation

@pmusaraj
Copy link
Contributor

@pmusarajpmusaraj commentedDec 16, 2025•
edited
Loading

This relies ondiscourse/discourse_docker#1010

When email setup is skipped, we can register the site for Discourse ID. That means the admin (and other users), can signup/login without the site having working email at all. The goal of this feature is to simplify bootstrapping a test site. A well-functioning community will likely need working email at some point, this simplifies the first step of getting started.

Screenshot when ID auth is available:

CleanShot 2025-12-17 at 10 26 56@2x

Screenshots when setup cannot continue:

CleanShot 2025-12-17 at 10 27 48@2xCleanShot 2025-12-17 at 10 28 40@2x

rishabhnambiar reacted with heart emoji
@github-actionsgithub-actionsbot added the i18nPRs which update English locale files or i18n related code labelDec 16, 2025
@pmusarajpmusaraj marked this pull request as ready for reviewDecember 17, 2025 15:22
@ZogStriPZogStriP self-requested a reviewDecember 17, 2025 15:32
defvisit_index
visit("/finish-installation")
defhas_discourse_id_button?
page.has_css?(".finish-installation__discourse-id",text:"Login with Discourse ID")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should the "text:" useI18n instead?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it's clearer withoutI18n personally... we use both in core afaik.

@pmusaraj
Copy link
ContributorAuthor

I think I addressed you main comments here@ZogStriP, can you give this another look.

ZogStriP reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ZogStriPZogStriPZogStriP approved these changes

Assignees

No one assigned

Labels

i18nPRs which update English locale files or i18n related code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pmusaraj@ZogStriP
[8]ページ先頭
©2009-2025 Movatter.jp