- Notifications
You must be signed in to change notification settings - Fork8.6k
DEV: Deprecate widgets#33684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
megothss wants to merge8 commits intomainChoose a base branch fromdev/no-more-widgets
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
DEV: Deprecate widgets#33684
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…estsRewrote the `AvatarFlair` component using Glimmer, removing legacy `MountWidget` usage.Improved maintainability with helper functions for styles and icon handling.Added integration tests to ensure correct rendering for icon and image flair scenarios.
Refactored `POST_STREAM_DEPRECATION_OPTIONS` and other deprecation logic into `widget.js` for consistent handling across the codebase. Introduced `warnWidgetsDeprecation` to streamline warnings. Updated various widget-related usages and tests to align with the new approach.
…oballyIntroduced the `deactivate_widgets_rendering` site setting to allow global deactivation of widget rendering. Updated `createWidget`, `MountWidget`, and `registerWidgetShim` to respect this setting by halting execution if widgets are deactivated. Added checks and logic across relevant components to ensure smooth behavior when widgets are turned off.
Updated the default configuration of the `deactivate_widgets_rendering` site setting from "yes" to "no".
Updated the `deactivate_widgets_rendering` site setting to use a boolean instead of an enum. Adjusted related logic in `createWidget`, `MountWidget`, and `registerWidgetShim` to align with this change. Simplified configuration in `site_settings.yml` by replacing choices with a default `false`.
…localizationChanged the default value of `deactivate_widgets_rendering` to `true` in `site_settings.yml` and added a corresponding localization string to `server.en.yml`. This aligns with ongoing efforts to phase out legacy widget rendering.
…er_post_stream`Updated the `deactivate_widgets_rendering` setting to unconditionally enable the Glimmer Post Stream regardless of the `glimmer_post_stream_mode` setting. Adjusted related logic in the `site` model and updated the localization string for clarity.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.