Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add missing fields update implementations#25331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
br41nslug wants to merge3 commits intobr41nslug/now-809
base:br41nslug/now-809
Choose a base branch
Loading
fromindexes-api-consistency

Conversation

br41nslug
Copy link
Member

@br41nslugbr41nslug commentedJun 20, 2025•
edited
Loading

Fixes#25330

Builds on top of#25199

Scope

What's changed:

  • Added theupdateFields() REST command to the SDK
  • Added support for theconcurrentIndexCreation option in the SDK
  • Added a graphql resolver for updating multiple fields

Potential Risks / Drawbacks

  • Lorem ipsum dolor sit amet

Review Notes / Questions

  • Anything else that was missed?
  • Didnt push the commits toAdd retention indexes #25199 because it already has seen a bunch of review and testing. Feel free to merge it into its parent PR Ian if this is overkill 😉

@br41nslugbr41nslug requested a review froma team as acode ownerJune 20, 2025 18:51
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJun 20, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:31e6db6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@br41nslugbr41nslug marked this pull request as draftJune 20, 2025 18:52
Copy link
Contributor

@ComfortablyCodingComfortablyCoding left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tests

  • Expect sdk to acceptconcurrentIndexCreation on create collection query
  • Expect sdk to acceptconcurrentIndexCreation on create field. FAIL. No option is present
  • Expect sdk to acceptconcurrentIndexCreation on batch field update
  • Expect sdk to acceptconcurrentIndexCreation on field update
  • Expect batch update fields to be avaialable via an sdk method (updateFields)

Copy link
Contributor

@ComfortablyCodingComfortablyCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ComfortablyCodingComfortablyCodingComfortablyCoding approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing sdk/gql implementation for updating multiple fields
2 participants
@br41nslug@ComfortablyCoding
[8]ページ先頭
©2009-2025 Movatter.jp