- Notifications
You must be signed in to change notification settings - Fork571
Fix/handle missing digger config gracefully#2517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
joshuamkite-nfb wants to merge4 commits intodiggerhq:developChoose a base branch fromcheckatrade-dev:fix/handle-missing-digger-config-gracefully
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix/handle missing digger config gracefully#2517
joshuamkite-nfb wants to merge4 commits intodiggerhq:developfromcheckatrade-dev:fix/handle-missing-digger-config-gracefully
+189 −55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Added nil checks in GitHub payload processing to prevent panics- Added helper functions getStringValue and getWorkflowCommands for safe access- Updated integration test JSON to include missing sender and repository fields
ContributorAuthor
joshuamkite-nfb commentedDec 16, 2025
Looks like |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Problem
Digger wassporadically showing git cloning errors in repositories that don't have Digger configured:
Root Cause
These issue appear to occur when the background projects refresh service and GitHub Actions process repositories without digger.yml files:
generateProjects=trueThe
generateProjects=trueparameter is hardcoded in multiple places, e.g.:cli/pkg/github/github.go:111background/projects-refresh-service/projects_refesh_main.go:49backend/controllers/github_helpers.go:865-866Solution
Modified
LoadDiggerConfigYamlfunction to handle missing configuration files gracefully by returning an empty configuration instead of an error when no config file is found.Changes
copyWorkflowConfigurationto prevent panic when workflow config is nilgetStringValueandgetWorkflowCommandsTesting
go test -v)Impact
🧠AI Usage Details:
Used Claude (Anthropic's AI assistant) for: