- Notifications
You must be signed in to change notification settings - Fork85
Description
Used to be the case with Webpack 4 that we could pass[path][name].[contenthash] as the name template for workerize-loader to use; and we'd get workers output into a folder structure mirroring their original source location.
This was nice for debugging purposes to easily identify workers, because the entry point file for esp. larger workers is usually some kind ofindex.js file.[path] means you don't need to inspect every separate worker namedindex.[hash].worker.js - and it prevented name collisions when you would generate names in development builds without hash fingerprints in them.
As of Webpack 5, that functionality appears to be broken. It resolves[name] and[contenthash] just fine, but doesn't know how to deal with[path].
I'm using a plugin to dynamically inject options into loaders to configure bare loader URLs such as
importworkerfrom"workerize-loader!./path-to/worker"
centrally, and luckily I was able to extend the logic there to use the current compilation context and module context to compute a relative path, but yeah...this is not very ergonomic, easily understood or maintainable:
newInjectOptionsPlugin({loaders :{"workerize-loader" :(module,compilation)=>{constcontext=path.relative(compilation.options.context,module.context);.replace(/\\/g,"/");return{name :dev ?`${context}[name]` :"${context}[name].[contenthash]`};}}})
compared to what itused to be:
newInjectOptionsPlugin({loaders :{"workerize-loader" :{name :dev ?"[path][name]" :"[path][name].[contenthash]"}}})