NotificationsYou must be signed in to change notification settings
Fork137
Star2.9k

fix #171 - remove warnings about deprecated hook on react 16.9.0^#172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

developit merged 4 commits intodevelopit:masterfromAkiyamka:fix-will-receive-props

Jun 17, 2020

Merged

fix #171 - remove warnings about deprecated hook on react 16.9.0^#172

developit merged 4 commits intodevelopit:masterfromAkiyamka:fix-will-receive-props

Jun 17, 2020

Conversation

Copy link

Contributor

Akiyamka commentedAug 23, 2019

This will fix issue with warnings.
Probably will be better migrate to getDerivedStateFromProps hook with null return, but I not sure how I can call static method it this case

Akiyamka added2 commits

August 23, 2019 13:38

fixdevelopit#171- remove warnings about deprecated hook on react 16…

db87ca6

….9.0^

revert change in preact intecgration

06d6834

Copy link

Contributor

eduardoborges commentedAug 25, 2019

Very nice ;)

eduardoborges approved these changes

Aug 25, 2019

View reviewed changes

developit reviewed

Sep 4, 2019

View reviewed changes

src/integrations/react.jsShow resolvedHide resolved

Akiyamkaand others added2 commits

November 14, 2019 12:30

Update src/integrations/react.js

347533b

Co-Authored-By: Jason Miller <developit@users.noreply.github.com>

revert: back to componentWillReceiveProps

82d9e5b

Copy link

Komzpa commentedDec 2, 2019

Hi! Can this be merged, or is there any other thing to adjust? :)

Copy link

@Akiyamka hello stranger. i opened a couple of pull requests with rather substantial changes that i personally think greatly improves unistore and was looking for some feedback on. i'm assuming@developit is busy and meanwhile i was hoping to get this feedback from elsewhere. since you have opened a pull request yourself i assume you are familiar with the package and would love to hear what you think about the changes i propose. you can find them at#182 and#183. the second one builds upon the changes from the first.