NotificationsYou must be signed in to change notification settings
Fork202
Star5.7k

fix: invalid path for export in package.json (v 5.0.0)#164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

cristianoliveira wants to merge2 commits intodevelopit:main

base:main

Choose a base branch

fromcristianoliveira:main

Open

fix: invalid path for export in package.json (v 5.0.0)#164

cristianoliveira wants to merge2 commits intodevelopit:mainfromcristianoliveira:main

Conversation

Copy link

cristianoliveira commentedFeb 10, 2023

First of all, thanks for this library! We have been using it for quite a long time, and it works like a charm.

Description

It seems that there are invalid values exported in the package.jsonhttps://github.com/developit/unfetch/blob/main/package.json#L18

It causes issue while usingunfetch as a module, for instance, we use webpack and once upgraded to 5.0.0 it started to break the build with the given (not so clear, to say the least) error:

ERROR in ./src/index.js 1:0-30Module not found: Error: Can't resolve 'unfetch' in '/Users/user/dev/unfetch-issue-demo/src'resolve 'unfetch' in '/Users/user/dev/unfetch-issue-demo/src'  Parsed request is a module  using description file: /Users/user/dev/unfetch-issue-demo/package.json (relative path: ./src)    Field 'browser' doesn't contain a valid alias configuration    resolve as module      /Users/user/dev/unfetch-issue-demo/src/node_modules doesn't exist or is not a directory      looking for modules in /Users/user/dev/unfetch-issue-demo/node_modules        single file module          using description file: /Users/user/dev/unfetch-issue-demo/package.json (relative path: ./node_modules/unfetch)            no extension              Field 'browser' doesn't contain a valid alias configuration              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch is not a file            .tsx              Field 'browser' doesn't contain a valid alias configuration              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.tsx doesn't exist            .ts              Field 'browser' doesn't contain a valid alias configuration              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.ts doesn't exist            .js              Field 'browser' doesn't contain a valid alias configuration              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.js doesn't exist            .jsx              Field 'browser' doesn't contain a valid alias configuration              /Users/user/dev/unfetch-issue-demo/node_modules/unfetch.jsx doesn't exist        existing directory /Users/user/dev/unfetch-issue-demo/node_modules/unfetch...

Demo

Here you can see an example of this issue:
https://github.com/cristianoliveira/unfetch-issue-demo

Solution

After pointing tosrc/index.mjs it started to compile again and it is working as expected. 😄

Let me know if this is the right solution.

Relates to

#163
#162

fix: invalid path for export in package.json

bd42482

Copy link

Author

cristianoliveira commentedFeb 10, 2023•
edited
Loading

For those who use webpack and want a quick fix, while this isn't correctly addressed, you can create an alias and point to the correct file:

In the webpack.config.js include:

resolve:{alias:{'unfetch':path.resolve(__dirname,'node_modules/unfetch/dist/unfetch.mjs'),},},

rschristian reviewed

Feb 15, 2023

View reviewed changes

package.json OutdatedShow resolvedHide resolved

fix: point to dist files

d0ccf20

Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>

cristianoliveira requested a review fromrschristian

February 15, 2023 16:08

Copy link

rschristian commentedFeb 15, 2023

Looks correct to me!

enzoferey mentioned this pull request

Feb 16, 2023

fix: resolve unfetch package entrypoint properlyenzoferey/network-gas-price#16

Merged

TheLuckyLuc mentioned this pull request

Mar 16, 2023

Downgradeisomorphic-unfetch package from 4.0.2 to 4.0.0HubbleHQ/request#28

Merged

narthur approved these changes

Mar 24, 2023

View reviewed changes

Copy link

ayZagen commentedMar 27, 2023•
edited
Loading

@rschristian @developit pinging in case you have forgotten to approve

Copy link

rschristian commentedMar 28, 2023

Sorry, not a maintainer, my approval does nothing. Just a drive-by suggestion as I ran into this and was seeing if anyone had submitted a fix yet.

NickMcBurney mentioned this pull request

May 4, 2023

unfetch@5.0.0 published package might be missing files#162

Open

Copy link

denizsult commentedJun 1, 2023

For those who use webpack and want a quick fix, while this isn't correctly addressed, you can create an alias and point to the correct file:
In the webpack.config.js include:
resolve:{alias:{'unfetch':path.resolve(__dirname,'node_modules/unfetch/dist/unfetch.mjs'),},},

Workes fine. Thanks

rschristian mentioned this pull request

Aug 1, 2023

Fixed module not found: Can't resolve 'unfetch'#173

Open

martaver mentioned this pull request

Aug 3, 2023

[Bug]: use of isomorphic-unfetch breaks storybook-next buildstorybookjs/storybook#23700

Open

jonathansick added a commit to lsst-sqre/squareone that referenced this pull request

Aug 15, 2023

Downgrade unfetch to 4.2.0

51594db

This is pending a fix to a how unfetch 5 exports its files, e.g.developit/unfetch#164

jonathansick added a commit to lsst-sqre/squareone that referenced this pull request

Aug 16, 2023

Downgrade unfetch to 4.2.0

a40bbe3

This is pending a fix to a how unfetch 5 exports its files, e.g.developit/unfetch#164

juicy-g mentioned this pull request

Sep 9, 2023

Module not found: Can't resolve 'unfetch'alexandermendes/ra-supabase-media-library#1

Open

Copy link

Skopea commentedSep 9, 2023

Can this be merged? I really need this change since in cannot start storybook in my project, Thanks for fixing this! 🥳

Skopea approved these changes

Sep 9, 2023

View reviewed changes

Copy link

alinasir85 commentedOct 23, 2023

@rschristian , Kindly approve & merge it

Copy link

rschristian commentedOct 23, 2023

@rschristian , Kindly approve & merge it

#164 (comment)

Copy link

alinasir85 commentedOct 23, 2023

@rschristian , Kindly approve & merge it
#164 (comment)

But its showing that your review is pending..

Copy link

rschristian commentedOct 23, 2023

Doesn't matter -- GitHub's UI is a bit weird there for sure, but the approval of non-maintainers does nothing. You'd see a "collaborator" badge (I think) next to my name if I was able to approve and merge.

Copy link

alinasir85 commentedOct 23, 2023

@developit ?

alinasir85 mentioned this pull request

Oct 24, 2023

[Dependency Issue] Isomorphic-unfetch: invalid path for export in package.jsonToucanProtocol/toucan-sdk#95

Closed

Copy link

katerberg commentedOct 24, 2023

This would be really nice to have merged since it currently is unusable invite without a manual override.

For anyone else usingvite, adding a resolve alias solved this for now:

defineConfig({  resolve: {    alias: {      unfetch: path.resolve(__dirname, "node_modules/unfetch/dist/unfetch.mjs"),    }  }})

Copy link

tdacu commentedNov 16, 2023•
edited
Loading

This would be really nice to have merged since it currently is unusable invite without a manual override.

=> Failed to build the preview
ReferenceError: path is not defined

And if I'm importing

import path from 'path';

I'm still getting
Error: Failed to resolve entry for package "unfetch". The package may have incorrect main/module/exports specified in its package.json.

pheuberger added a commit to pheuberger/toucan-sdk that referenced this pull request

Nov 29, 2023

fix: downgradeisomorphic-unfetch to 4.0.0

b668a1d

Without this patch people were experiencing problems when bundling theSDK. See issueToucanProtocol#95ToucanProtocol#95The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch`5.0.0 which currently has an issue with their module exports leading toan error when bundling the lib itself or any other lib that depends on`unfetch`.See this PR for more information:developit/unfetch#164Once this PR is merged we can go back to the latest `isomorphic-unfetch`version.

pheuberger mentioned this pull request

Nov 29, 2023

P2: fix: downgradeisomorphic-unfetch to 4.0.0ToucanProtocol/toucan-sdk#104

Merged

pheuberger added a commit to pheuberger/toucan-sdk that referenced this pull request

Nov 29, 2023

fix: downgradeisomorphic-unfetch to 4.0.0

6c8c6a0

Without this patch people were experiencing problems when bundling theSDK. See issueToucanProtocol#95ToucanProtocol#95The problem is that `isomorphic-unfetch` 4.0.2 upgraded to `unfetch`5.0.0 which currently has an issue with their module exports leading toan error when bundling the lib itself or any other lib that depends on`unfetch`.See this PR for more information:developit/unfetch#164Once the PR above is merged we can go back to the latest `isomorphic-unfetch`version.

pheuberger mentioned this pull request

Nov 29, 2023

Change isomorphic-unfetch to track latest version againToucanProtocol/toucan-sdk#105

Open

Copy link

tim-kilian commentedMar 28, 2024

Can someone merge this, please?

unflxw added a commit to appsignal/appsignal-javascript that referenced this pull request

Apr 23, 2024

Useisomorphic-unfetch@4.0.0 specifically

ebc7305

An issue with `unfetch@5`, depended on by `isomorphic-unfetch@4.0.2`,breaks bundling with tools such as `esbuild` and `webpack`:developit/unfetch#164

This was referencedApr 23, 2024

Removeisomorphic-unfetch dependency from@appsignal/coreappsignal/appsignal-javascript#622

Merged

Bump isomorphic-unfetch in @appsignal/coreappsignal/appsignal-javascript#621

Closed

Copy link

alopix commentedAug 27, 2024

Any chance this can get merged and published? Lots of bundler workarounds required right now 😅

BohdanOne mentioned this pull request

Sep 2, 2024

fix(deps): path to unpatch moduleprismicio/slice-machine#1453

Merged

3 tasks

Copy link

katerberg commentedApr 30, 2025

@developit is this possible to merge? Not sure on the status on the library, but this one would be a really helpful fix.

Labels

None yet

11 participants

Movatterモバイル変換

fix: invalid path for export in package.json (v 5.0.0)#164

Are you sure you want to change the base?

fix: invalid path for export in package.json (v 5.0.0)#164

Uh oh!

Conversation

cristianoliveira commentedFeb 10, 2023

Description

Demo

Solution

Relates to

Uh oh!

cristianoliveira commentedFeb 10, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rschristian commentedFeb 15, 2023

Uh oh!

ayZagen commentedMar 27, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

rschristian commentedMar 28, 2023

Uh oh!

denizsult commentedJun 1, 2023

Uh oh!

Skopea commentedSep 9, 2023

Uh oh!

alinasir85 commentedOct 23, 2023

Uh oh!

rschristian commentedOct 23, 2023

Uh oh!

alinasir85 commentedOct 23, 2023

Uh oh!

rschristian commentedOct 23, 2023

Uh oh!

alinasir85 commentedOct 23, 2023

Uh oh!

katerberg commentedOct 24, 2023

Uh oh!

tdacu commentedNov 16, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

tim-kilian commentedMar 28, 2024

Uh oh!

alopix commentedAug 27, 2024

Uh oh!

katerberg commentedApr 30, 2025

Uh oh!

Uh oh!

cristianoliveira commentedFeb 10, 2023•
edited
Loading

ayZagen commentedMar 27, 2023•
edited
Loading

tdacu commentedNov 16, 2023•
edited
Loading