- Notifications
You must be signed in to change notification settings - Fork202
Fix Typescript export definitions#116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
vincentcr wants to merge2 commits intodevelopit:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Typescript does not support .mjs file, so the module that ends up beingimported is the commonJS version (`dist/unfetch.js`). Since it does not contain a"default" export entry, using it in Typescript results in a runtimeerror: `TypeError: isomorphic_unfetch_1.default is not a function`Fix by reverting to `export =`. To use in Typescript, use the form`import * as fetch from "isomorphic-unfetch"`.
shevchenkonik commentedJun 18, 2019
Yes, I have similar problem and this PR will solve it. Thanks@vincentcr |
I believe this should be addressed by#135, which drops the |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typescript does not support .mjs files, so the module that ends up being imported is the commonJS version (
dist/unfetch.js). Since that file does not contain adefaultexport entry, using it in Typescript results in a runtime error:TypeError: isomorphic_unfetch_1.default is not a functionFix by reverting to
export =. To use in Typescript, use the formimport * as fetch from "isomorphic-unfetch".