- Notifications
You must be signed in to change notification settings - Fork405
-
Hi, I have generated a pull request#571to modify the features schema and also added a proposal and examples of how extending the schema can facilitate feature development. I would like this committed to the repo. There is very little activity in the repo and I am also seeing spam in the issues that no one has cleaned up. Can someone who is administering this repo please review my submission.@bamurtaugh@Chuxel |
BetaWas this translation helpful?Give feedback.
All reactions
Replies: 2 comments 7 replies
-
I have made the proposal and pull request some time ago. I have answered all questions concerning the pull request, but there is no movement forward. I am not sure who is looking after this project but I would appreciate progress with the pull request as I don't want to fork but contribute to this project to use my changes. |
BetaWas this translation helpful?Give feedback.
All reactions
-
I think I may be missing where the answers happened. For instance, I'm not sure where your response to the comment#571 (comment) is - could you please link it here? Thanks so much! |
BetaWas this translation helpful?Give feedback.
All reactions
-
I am copying what I am seeing because I don't understand why it is not visible. The links are embeded:scriptjs started a review Proposed SolutionExtend the Dev Container Feature Options Schema by introducing Based on the proposal and the examples, the supported value types would include: strings (for single values, like a name or path), proposals/add-array-object-feature-option-types.md Install dependenciesecho "Installing dependencies..." Allowing Bash syntax gives feature authors more expressive power and flexibility—especially for complex logic, data structures (arrays/objects), and maintainability. The choice of shell should be left to the feature author, depending on their target audience and platform requirements. Imposing strict /bin/sh compatibility on all features can be unnecessarily limiting for those who are able and willing to depend on Bash, or who are building features for environments where Bash is always available. In summary: while POSIX compatibility is valuable for broad compatibility, there are valid cases where leveraging Bash-specific features is the pragmatic and efficient choice for feature development. Feature authors should be empowered to choose the best tool for their use case. proposals/add-array-object-feature-option-types.md Install dependenciesecho "Installing dependencies..." proposals/add-array-object-feature-option-types.md Install dependenciesecho "Installing dependencies..." Authoring Reference information about the application required to execute the Feature should be included in devcontainer-feature.json in the metadata section. Applications should default to /bin/sh for Features that do not include this information. If the Feature is included in a folder as part of the repository that contains devcontainer.json, no other steps are necessary. |
BetaWas this translation helpful?Give feedback.
All reactions
-
@bamurtaugh All of the pending content is at#571 (comment) |
BetaWas this translation helpful?Give feedback.
All reactions
-
@bamurtaugh I'd appreciate a response so the changes can either be accepted or whether I will have to fork. I made the pull request in April and it is now Aug. |
BetaWas this translation helpful?Give feedback.
All reactions
-
@scriptjs the link you share just brings me to@chrmarti's comment - I don't see your reply. On my end, I still see the same several open review comments without your responses. Could you please share a screenshot here if you see you have replied to these comments, so that we can work on resolving them together? Or could you please try replying again? Thank you! |
BetaWas this translation helpful?Give feedback.
All reactions
-
What do I need to do? …On Fri, Jul 11, 2025, 2:06 AM scriptjs ***@***.***> wrote:@bamurtaugh <https://github.com/bamurtaugh> All of the pending content is at#571 (comment) <#571 (comment)> — Reply to this email directly, view it on GitHub <#573 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BTOC3AN5DF5CX2TCRKFV6AL3H4E2HAVCNFSM6AAAAAB3W4JG6GVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTGNZSGY3DMNI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***> |
BetaWas this translation helpful?Give feedback.