- Notifications
You must be signed in to change notification settings - Fork366
feat(XingxinHE): add feature registry#624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:gh-pages
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| maintainer:XingxinHE | ||
| contact:https://github.com/XingxinHE/devcontainer-features/issues | ||
| repository:https://github.com/XingxinHE/devcontainer-features | ||
| ociReference:ghcr.io/XingxinHE/devcontainer-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for the PR. The ORAS spec requires the ociReference to be in lower case. Would you kindly update the same.
The supporting tools do help convert the case, however, its better to sync as much as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hey@Kaniska244 ,
Thx for the review. Just double check, I am only required to change theXingxinHE of theociReference field into lowercase. While others are fine, am I correct?
What type of PR is this?
Related Issues
Description
Add devcontainer features to the registry.
zivid,realsense, androbotpkgand they are not in the registry yet. Add tests to conver them already.Seehttps://github.com/XingxinHE/devcontainer-features for more.
Collection checklist
If your PR contributes a new collection, please utilize this checklist: