- Notifications
You must be signed in to change notification settings - Fork106
run the parsing of pieces for post-comma parts prior to checking if a…#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
derek73 merged 1 commit intoderek73:masterfromrAndrewNichol:add_pre_comma_suffixes_prior_to_parsingDec 12, 2019
Merged
run the parsing of pieces for post-comma parts prior to checking if a…#98
derek73 merged 1 commit intoderek73:masterfromrAndrewNichol:add_pre_comma_suffixes_prior_to_parsingDec 12, 2019
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ll post-comma elements are suffixes. this ensures that suffixes are properly captured in the constants prior to the all-suffix check
ContributorAuthor
rAndrewNichol commentedNov 20, 2019
Hi@derek73 - any interest in this PR? any followup from me you'd like? |
Owner
derek73 commentedNov 20, 2019 via email
Yes but I am traveling and won’t be able to take a closer look until next week sometime. … On Nov 19, 2019, at 4:15 PM, Andrew Nichol ***@***.***> wrote: Hi@derek73 - any interest in this PR? any followup from me you'd like? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. |
Owner
derek73 commentedDec 12, 2019
Thanks for the pull request. Looks like you had to go pretty far down the rabbit hole to unravel that one. :) I appreciate it. Sorry it took so long to get this merged. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ll post-comma elements are suffixes. this ensures that suffixes are properly captured in the constants prior to the all-suffix check.
This is to fix an inconsistency issue where a name would get misparsed the first time it was parsed and correctly parsed any subsequent times.
Upstream:
With Fix:
Tests were identical to upstream, 11 expected failures.