- Notifications
You must be signed in to change notification settings - Fork103
fix!: Change default output directory tobuild/reports/dependency-check to avoid clash with other reports#483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
chadlwilson wants to merge2 commits intodependency-check:mainChoose a base branch fromchadlwilson:change-default-outputdir
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…lugins & Gradle itselfSigned-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
build/reports/dependency-check to avoid clash with other reportsbuild/reports/dependency-check to avoid clash with other reportsContributor
jeremylong commentedOct 22, 2025
I completely agree with the change - but this could be considered breaking by some. We do have plans for other breaking changes to be released soon. I'll include this then. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Note that this is amildly breaking change so might want to consider that, although if people are sensitive to the location, you'd hope they'd configure it specifically. Technically
12.1.8was also a mildly breaking change when the directory got marked as an@OutputDirectoryas it made Gradle explicitly aware of the ordering problems between tasks, rather than discovering it later.Setting to the current
build/reportsdirectory tends to break task caching for other plugins since many of them put things into/reportsincluding Gradle'sreports/problems/problems-report.html, test reports intoreports/tests. When ODC writes things there, Gradle isn't sure what to do as it implies ordering issues between tasks, either causing tasks to unnecessarily re-run, or users to need to define dependencies between tasks, which is quite confusing.It requires a fair bit of Gradle experience to figure out that the ODC directory needs to be changed to work around it.
@OutputFIles instead (which would be backward compatible) but that's not so safe/easy to do with the interface to ODC.@InputDirectory->@Input.@InputDirectoryis for directories whose contents you care about, and where it should cause the task to re-run if cached. In this case we only care about the path, not the contents.TODO afterwards