Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix!: Change default output directory tobuild/reports/dependency-check to avoid clash with other reports#483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chadlwilson wants to merge2 commits intodependency-check:main
base:main
Choose a base branch
Loading
fromchadlwilson:change-default-outputdir

Conversation

@chadlwilson
Copy link
Collaborator

@chadlwilsonchadlwilson commentedOct 16, 2025
edited
Loading

Note that this is amildly breaking change so might want to consider that, although if people are sensitive to the location, you'd hope they'd configure it specifically. Technically12.1.8 was also a mildly breaking change when the directory got marked as an@OutputDirectory as it made Gradle explicitly aware of the ordering problems between tasks, rather than discovering it later.

Setting to the currentbuild/reports directory tends to break task caching for other plugins since many of them put things into/reports including Gradle'sreports/problems/problems-report.html, test reports intoreports/tests. When ODC writes things there, Gradle isn't sure what to do as it implies ordering issues between tasks, either causing tasks to unnecessarily re-run, or users to need to define dependencies between tasks, which is quite confusing.

It requires a fair bit of Gradle experience to figure out that the ODC directory needs to be changed to work around it.

  • I considered declaring a set of@OutputFIles instead (which would be backward compatible) but that's not so safe/easy to do with the interface to ODC.
  • Changed@InputDirectory ->@Input.@InputDirectoryis for directories whose contents you care about, and where it should cause the task to re-run if cached. In this case we only care about the path, not the contents.

TODO afterwards

  • Update website documentation

…lugins & Gradle itselfSigned-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
@jeremylongjeremylong changed the titlefix: Change default output directory tobuild/reports/dependency-check to avoid clash with other reportsfix!: Change default output directory tobuild/reports/dependency-check to avoid clash with other reportsOct 22, 2025
@jeremylong
Copy link
Contributor

I completely agree with the change - but this could be considered breaking by some. We do have plans for other breaking changes to be released soon. I'll include this then.

chadlwilson reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@OutputDirectory conflicts with other plug-ins

2 participants

@chadlwilson@jeremylong

[8]ページ先頭

©2009-2025 Movatter.jp