- Notifications
You must be signed in to change notification settings - Fork1.5k
Add file mapping to phpstan#4685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add file mapping to phpstan#4685
Uh oh!
There was an error while loading.Please reload this page.
Conversation
See help ale-lint-other-machines for more info about filename-mapping.
EdwinHuijsing commentedDec 17, 2023
I just rerun the docker test Any ideas who to fixes this? I can't test on windows (i don't have windows), so i am out of options. Regards, |
EdwinHuijsing commentedJan 16, 2024
Yesterday while working on an other linter, i found that we do not need the filename. More testing is needed before i can push the changes Regards, |
We only needed to refactor the processing loop.No extra test are needed.
hsanson left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
* PHPStan is now working with filename-mappingSee help ale-lint-other-machines for more info about filename-mapping.* Add two tests to show and test what is expected* Missed this update while creating previous commit* Simplified the updateWe only needed to refactor the processing loop.No extra test are needed.
This should solve issue#4372 "phpstan filename mappings not respected when running via docker".
Vim 8 caused a problem in one test, because the error vim returns is not the same as the other three.