- Notifications
You must be signed in to change notification settings - Fork736
fix: prevent island names from shadowing JavaScript globals#3522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
marvinhagemeister merged 5 commits intodenoland:mainfromfry69:fry69/fix-filenames-reserved-keywordsOct 5, 2025
Merged
fix: prevent island names from shadowing JavaScript globals#3522
marvinhagemeister merged 5 commits intodenoland:mainfromfry69:fry69/fix-filenames-reserved-keywordsOct 5, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
marvinhagemeister approved these changesOct 5, 2025
Collaborator
marvinhagemeister left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
84576bd intodenoland:main 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
fix#3521
Generated PR message below
Problem
Island files named after JavaScript global objects (e.g., Map.tsx,
Set.tsx,Promise.tsx) cause runtime errors. WhenUniqueNamergenerates identifiers from these filenames, the resulting variable names shadow global constructors, breaking instantiation:This results in
TypeError: Map is not a constructorwhen the framework attempts to usenew Map()internally.Solution
Added JavaScript global objects to the
JS_RESERVEDset inUniqueNamer. Names matching reserved keywords or globals are now automatically prefixed with underscore:Changes
utils.ts: Extended
JS_RESERVEDwith:Integration tests: Added test cases for both Builder and Vite build systems verifying islands named after globals work correctly
Impact
Single-location fix in
UniqueNamerapplies to all code generation (islands, routes, etc.). Island names are prefixed when needed, preserving debuggability while preventing shadowing bugs.