Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#963 Update Gradle build mechanism to support Kotlin DSL with Gradle v6.3#974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
loxal wants to merge2 commits intodeeplearning4j:master
base:master
Choose a base branch
Loading
fromloxal:master

Conversation

loxal
Copy link
Contributor

  • provide specific & tested Gradle version to guarantee a working example
  • convert dynamically-typed Gradle script to statically-typed Kotlin DSL
  • update dependencies
  • cleanup imports

…L with the latest Gradle v6.3* provide specific & tested Gradle version to guarantee a working example* convert dynamically-typed Gradle script to statically-typed Kotlin DSL* update dependencies* cleanup importsSigned-off-by: Alex <alexander.orlov@loxal.net>
@saudetsaudet requested a review fromRobAltenaApril 20, 2020 03:15
Copy link
Contributor

@RobAltenaRobAltena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. Thank you!

loxal reacted with hooray emoji
@saudetsaudet requested a review fromtreoApril 23, 2020 01:31
@loxal
Copy link
ContributorAuthor

@treo are you going to merge this PR to master at some point?

@treo
Copy link
Member

There is a bigger example repository restructuring coming in a few days, in order to not loose this PR in the aftermath, I'm keeping it open to add it in afterwards and to make sure that the attribution doesn't get lost.

loxal reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@RobAltenaRobAltenaRobAltena approved these changes

@treotreoAwaiting requested review from treo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@loxal@treo@RobAltena

[8]ページ先頭

©2009-2025 Movatter.jp