Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: corrects order to the release workflow#583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
lukeocodes merged 1 commit intomainfromlo/oops
Oct 2, 2025
Merged

Conversation

@lukeocodes
Copy link
Contributor

@lukeocodeslukeocodes commentedOct 2, 2025
edited by coderabbitaibot
Loading

Summary by CodeRabbit

  • Chores
    • Adjusted CI release workflow: publishing now occurs after the automated release process completes, rather than after tests.
    • No user-facing functionality changes; app behavior remains the same.
    • May slightly shift timing of published packages and release notes, aligning availability with release creation.
    • Documentation and versioning outputs remain consistent; no action required from users.

@coderabbitai
Copy link
Contributor

coderabbitaibot commentedOct 2, 2025
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The publish job’s dependency in .github/workflows/release-please.yml is changed to require the release-please job instead of the test job. This alters the workflow control flow so publish executes after release-please completes. No steps or other logic are modified.

Changes

Cohort / File(s)Summary
CI workflow dependency update
.github/workflows/release-please.yml
Adjusted publish jobneeds fromtest torelease-please, changing execution order; no other steps changed.

Sequence Diagram(s)

sequenceDiagram    participant GH as GitHub Actions    participant RP as release-please job    participant T as test job    participant P as publish job    GH->>RP: Run release-please    GH->>T: Run tests (independent)    Note over P: New dependency    RP-->>P: On success, allow publish    T--xP: No longer gates publish    GH->>P: Run publish after release-please
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • naomi-lgbt
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branchlo/oops

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and betweenb2e2538 and2bb25ee.

📒 Files selected for processing (1)
  • .github/workflows/release-please.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment@coderabbitai help to get the list of available commands and usage tips.

@lukeocodeslukeocodes merged commit3abbac3 intomainOct 2, 2025
12 of 13 checks passed
@lukeocodeslukeocodes deleted the lo/oops branchOctober 2, 2025 18:25
@github-actionsgithub-actionsbot mentioned this pull requestOct 2, 2025
@github-actionsgithub-actionsbot mentioned this pull requestOct 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@naomi-lgbtnaomi-lgbtnaomi-lgbt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukeocodes@naomi-lgbt

[8]ページ先頭

©2009-2025 Movatter.jp