- Notifications
You must be signed in to change notification settings - Fork111
fix: corrects order to the release workflow#583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
coderabbitaibot commentedOct 2, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Caution Review failedThe pull request is closed. WalkthroughThe publish job’s dependency in .github/workflows/release-please.yml is changed to require the release-please job instead of the test job. This alters the workflow control flow so publish executes after release-please completes. No steps or other logic are modified. Changes
Sequence Diagram(s)sequenceDiagram participant GH as GitHub Actions participant RP as release-please job participant T as test job participant P as publish job GH->>RP: Run release-please GH->>T: Run tests (independent) Note over P: New dependency RP-->>P: On success, allow publish T--xP: No longer gates publish GH->>P: Run publish after release-pleaseEstimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3abbac3 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Summary by CodeRabbit