Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Handle errors more effectively in plugins#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
r8ygun wants to merge3 commits intodeepfence:main
base:main
Choose a base branch
Loading
fromr8ygun:error-cleanup

Conversation

@r8ygun
Copy link
Contributor

The existing plugins did not handle errors particularly well in that they simply logged them within the context of their executing goroutine, which leaves the rest of the application blind to the errors. This PR attempts to exposed errors outside of their plugin goroutines so that we can be more opinionated on what should happen to a plugin in each case.

For now I have left the behaviour as logging.

@r8ygun
Copy link
ContributorAuthor

@vadorovsky in#20 you mentioned wanting to handle errors more effectively. I'd be interested in your thoughts on what we could do here.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@r8ygun

[8]ページ先頭

©2009-2025 Movatter.jp