Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Fix flaky spec on budget projects bulk assignation#13777

Merged
alecslupu merged 1 commit intodevelopfromfix/bulk-project-flaky
Dec 17, 2024

Conversation

microstudi
Copy link
Contributor

@microstudimicrostudi commentedDec 17, 2024
edited
Loading

🎩 What? Why?

Looks like there's a flaky related to a bulk assignation of taxonomies in budgets.
This PR should solve it.

The flaky failure:

Failures:  1) Admin manages projects bulk actions changes projects taxonomies     Failure/Error: expect(Decidim::Budgets::Project.find(project.id).taxonomies.first).to eq(taxonomy)       expected: #<Decidim::Taxonomy id: 38, name: {"en"=>"<script>alert(\"taxonomy_name\");</script> Dolorum aliquam ...: "2024-12-17 09:02:00.206770000 +0000", filters_count: 0, filter_items_count: 1, part_of: [38, 35]>            got: #<Decidim::Taxonomy id: 37, name: {"ca"=>"<script>alert(\"taxonomy_name\");</script> Adipisci minus p...: "2024-12-17 09:02:00.128647000 +0000", filters_count: 0, filter_items_count: 1, part_of: [37, 36]>       (compared using ==)       Diff:       @@ -1,21 +1,21 @@       -#<Decidim::Taxonomy:0x00007f54a0a7b6a0       - id: 38,       +#<Decidim::Taxonomy:0x00007f54a09ed710       + id: 37,         name:       -  {"en"=>       -    "<script>alert(\"taxonomy_name\");</script> Dolorum aliquam molestiae. 5680",       -   "ca"=>       -    "<script>alert(\"taxonomy_name\");</script> Molestias pariatur totam. 5681",       +  {"ca"=>       +    "<script>alert(\"taxonomy_name\");</script> Adipisci minus porro. 5663",       +   "en"=>       +    "<script>alert(\"taxonomy_name\");</script> Officia placeat aut. 5662",           "machine_translations"=>            {"es"=>       -      "<script>alert(\"taxonomy_name\");</script> Non qui deleniti. 5682"}},       +      "<script>alert(\"taxonomy_name\");</script> Aperiam laudantium est. 5664"}},         decidim_organization_id: 70,       - parent_id: 35,       + parent_id: 36,         weight: 0,         children_count: 0,       - taxonomizations_count: 0,       - created_at: Tue, 17 Dec 2024 09:02:00.192744000 UTC +00:00,       - updated_at: Tue, 17 Dec 2024 09:02:00.206770000 UTC +00:00,       + taxonomizations_count: 1,       + created_at: Tue, 17 Dec 2024 09:02:00.121874000 UTC +00:00,       + updated_at: Tue, 17 Dec 2024 09:02:00.128647000 UTC +00:00,         filters_count: 0,         filter_items_count: 1,       - part_of: [38, 35]>       + part_of: [37, 36]>

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@request-infoRequest Info
Copy link

It seems like you did not give us much information about what you are trying to do here. We would appreciate it if you could provide us with more info about this issue/PR!

@github-actionsgithub-actionsbot added module: budgets type: fixPRs that implement a fix for a bug labelsDec 17, 2024
@microstudimicrostudi changed the titlefix flaky spec on budget projects bulk assignationFix flaky spec on budget projects bulk assignationDec 17, 2024
@alecslupualecslupu added no-backportPull Requests that should not be backported flaky spec labelsDec 17, 2024
Copy link
Contributor

@alecslupualecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ran for about 50 times using the below line, and could not make it fail.

for i in $(seq 1 100); do echo $i ;  bin/rspec decidim-budgets/spec/system/admin_manages_projects_spec.rb:52 || break ; done

@alecslupualecslupu added this to the0.30.0 milestoneDec 17, 2024
@alecslupualecslupu merged commit9706453 intodevelopDec 17, 2024
58 of 62 checks passed
@alecslupualecslupu deleted the fix/bulk-project-flaky branchDecember 17, 2024 23:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alecslupualecslupualecslupu approved these changes

@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

Assignees

@alecslupualecslupu

Labels
flaky specmodule: budgetsno-backportPull Requests that should not be backportedtype: fixPRs that implement a fix for a bug
Projects
Archived in project
Milestone
0.30.0
Development

Successfully merging this pull request may close these issues.

3 participants
@microstudi@alecslupu@greenwoodt

[8]ページ先頭

©2009-2025 Movatter.jp