Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Improve UI for sorting options on comments#13670

Conversation

andra-panaite
Copy link
Contributor

🎩 What? Why?

I have added a new option, "Sort by," that is disabled within the select. I have also added styling to bold the default option for sorting that is used when the user does not choose from the dropdown.

📌 Related Issues

Link your PR to an issue

Testing

  1. Go on the proposal/ meeting page.
  2. Add a few comments.
  3. Observe the sorting dropdown for comments.

📷 Screenshots

Please add screenshots of the changes you are proposing
comments_sorting

♥️ Thank you!

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This pull request does not contain a valid label. Please add one of the following labels:['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']

@alecslupualecslupu self-assigned thisNov 15, 2024
@alecslupualecslupu added the type: changePRs that implement a change for an existing feature labelNov 15, 2024
github-actions[bot]
github-actionsbot previously approved these changesNov 15, 2024
Copy link
Contributor

@greenwoodtgreenwoodt left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice job! Everything seems to work with the addition of the Order name. If there one change I could request is perhaps making theSort by: translation slightly lighter shade colour (like grey), rather than the same of the resource names?


Screenshot 2024-11-18 at 09 20 06

github-actions[bot]
github-actionsbot previously approved these changesNov 18, 2024
@andra-panaite
Copy link
ContributorAuthor

Hi@greenwoodt!
I have tried to add a lighter color to the "Sort by" option, but it seems that the selected option will take the styling applied to the select, not the one on itself. To have a different color only on the "Sort by" option, we will need some JavaScript to target the select element and change its styling when the page is first loaded. Then, when the user chooses another option from the select, the initial styling will be put back.
Do you think I should do this way?

github-actions[bot]
github-actionsbot previously approved these changesNov 18, 2024
@greenwoodt
Copy link
Contributor

Hi@greenwoodt! I have tried to add a lighter color to the "Sort by" option, but it seems that the selected option will take the styling applied to the select, not the one on itself. To have a different color only on the "Sort by" option, we will need some JavaScript to target the select element and change its styling when the page is first loaded. Then, when the user chooses another option from the select, the initial styling will be put back. Do you think I should do this way?

If you have a solution, then yes this method would be fantastic! Thanks@andra-panaite!

@greenwoodt
Copy link
Contributor

@andra-panaite After further internal discussion regarding changes to blend the new Sort By string, removing thebold-font from the selection drop down will be enough to approve the PR to merge!

github-actions[bot]
github-actionsbot previously approved these changesNov 19, 2024
@andra-panaite
Copy link
ContributorAuthor

@greenwoodt I have removed the bold font from the select tag and now it looks like this:
comments_sorting

Is this the desired result?

github-actions[bot]
github-actionsbot previously approved these changesNov 19, 2024
greenwoodt
greenwoodt previously approved these changesNov 20, 2024
Copy link
Contributor

@greenwoodtgreenwoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍🏽

@andreslucena
Copy link
Member

The current behavior is weird, as it isn't the same when going the first time, and when changing it + refreshing it. It's a consistency issue problem at least.

sort-by.webm

@carolromero can you check this out and confirm that this is the intended behavior?

github-actions[bot]
github-actionsbot previously approved these changesDec 17, 2024
github-actions[bot]
github-actionsbot previously approved these changesDec 18, 2024
github-actions[bot]
github-actionsbot previously approved these changesDec 18, 2024
Copy link
Member

@andreslucenaandreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have some suggestions, can you check them out?

github-actions[bot]
github-actionsbot previously approved these changesJan 8, 2025
github-actions[bot]
github-actionsbot previously approved these changesJan 8, 2025
@andreslucenaandreslucena merged commit1ef2224 intodecidim:developJan 8, 2025
61 checks passed
mllocs pushed a commit that referenced this pull requestJan 9, 2025
* Added "Sort by" into the select dropdown* Resolved comment* Run linter* Removed bold style  from select* Resolved comment* Added changes only to mobile view* Running linters* Removed duplicated id* Fixed accessibility issues* Apply suggestions from code review* Apply review recommendation* Running linters* Fix accessibility---------Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto added a commit that referenced this pull requestJan 14, 2025
* develop: (27 commits)  WCAG navigation submenu (#13796)  Update gem dependencies (part 3) (#13849)  Prevent notifications for deleted users (#13812)  Retries NPM installation a couple times to prevent network timeouts (#13831)  Update gem dependencies (part 2) (#13839)  Enhance signature pdf export (#13778)  Fix HexaPDF dependency (#13834)  Fix flaky spec in authentication (#13827)  Merge upload field for documents and image on proposal admin form (#13735)  Update gem dependencies (#13835)  Upgrade erb_lint to 0.8.0 (#13833)  Fix flaky spec in geocoder (#13820)  Refactor modules mounting routes (#13294)  Upgrade check-spelling action (#13825)  Add missing images in the custom registration emails from meetings (#13632)  Add missing translations (#13793)  Fix proposal map performance with hundreds of markers (#13798)  Create multiple surveys within same Survey component (#13420)  Accountability bulk actions (#13730)  Improve UI for sorting options on comments (#13670)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alecslupualecslupualecslupu left review comments

@greenwoodtgreenwoodtgreenwoodt left review comments

@andreslucenaandreslucenaandreslucena approved these changes

@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

Labels
module: commentsmodule: coretype: changePRs that implement a change for an existing featuretype: featurePRs or issues that implement a new feature
Projects
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Comments Iteration
5 participants
@andra-panaite@greenwoodt@andreslucena@alecslupu@carolromero

[8]ページ先頭

©2009-2025 Movatter.jp