- Notifications
You must be signed in to change notification settings - Fork413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Disable search engine choice window for ChromeDriver in system specs#13282
Disable search engine choice window for ChromeDriver in system specs#13282
Conversation
Note that I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ahukkanen , using
$google-chrome --version Google Chrome 127.0.6533.99$chromedriver --version ChromeDriver 127.0.6533.99 (f31af5097d90ef5ae5bd7b8700199bc6189ba34d-refs/branch-heads/6533@{#1910})
I could not replicate the issue while testingdecidim-core/spec/system/account_spec.rb nordecidim-core/spec/system/homepage_spec.rb.
Since the handler is documentedhere--disable-search-engine-choice-screen: Disable the 2023+ search engine choice screen, i am approving this.
@alecslupu Accoding to the internet, I am not the only one experiencing this issue after updating to v127: https://stackoverflow.com/questions/78809256/disable-search-engine-choice-screen-with-chrome-and-selenium There may be some special configuration on your machine that prevents the window from showing but I believe with the default installation, it will show up. |
* develop: (43 commits) Enable admins answer to closed comments (#13027) Improve generic error messages (#13286) Add opt-in to newsletter when using OmniAuth registration method (#13077) Fix exceptions with `decidim-templates` when not added explicitly (#13263) Fix deleting a component which has reminders associated with it (#13281) Do not disclose Decidim version through the API (#13280) Fix character counter disposition and spacing with WYSIWYG (#13264) Make confirm page unload compatible with the current unload event standards and newer Chromium (#13283) Disable search engine choise window for ChromeDriver (#13282) Remove unnecessary expected spelling variant (#13287) Generalize the term "Geocoding enabled" (#13285) Add coauthor from comments in proposals (#13003) Provide bulk action answers to proposals through answers templates (#13057) Create taxonomies section in the general settings (#13112) Parametrize Chrome Driver (#13277) Fix proposals' preview spacing (#13265) Remove pagination configuration initializer (#13210) Add spring as dependency (#13235) New Crowdin updates (#13203) Add exception handling when the versioned model does not exists (#13236) ...
🎩 What? Why?
With the latest stable Chrome and ChromeDriver (127.0.6533.99) started to see the following errors in the console when trying to run any system specs:
Tried running the same spec in visual mode by disabling the headless mode of ChromeDriver, i.e. commenting out this line:
decidim/decidim-dev/lib/decidim/dev/test/rspec_support/capybara.rb
Line 60 in2596f59
And I saw the search engine selection screen on top of the window which prevents the screen from being closed (see the attached screenshot).
Testing
📷 Screenshots