- Notifications
You must be signed in to change notification settings - Fork413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove unecessary elements in fat footer for mobile views#13012
Conversation
@carolromero I've left a bit of a gap in the legal links, as I think having them too together can bring problems when clicking them with mobile (as in the thumb could be too big and the links too small). Let me know if you want to reduce that a bit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@andreslucena I've tested this and (unsurprisingly) it works great 👌
Very nice job! Perhaps reference#12592 if needed for the future. |
🎩 What? Why?
After the redesign, the footer has too many links and it's specially noisy in the mobile views. This PR fixes that by reducing lots of elements. I also fixed the social networks icons and played a bit with the gaps so it matches with the mockup from#13008
📌 Related Issues
Testing
📷 Screenshots
Before
After