- Notifications
You must be signed in to change notification settings - Fork413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix WYSIWYG migration error with non li elements inside lists#12626
Fix WYSIWYG migration error with non li elements inside lists#12626
Conversation
@fblupi can you check the rubocop offenses 🙏🏽 ? As you're only adding one line and this method is only used one time (with the migration), I'm OK with just disabling them. |
@andreslucena I have disabled those rules for the method and now the pipe is green 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Adding the |
* Fix WYSIWYG migration error with non li elements inside lists* Disable rubocop rules
🎩 What? Why?
Fix error in WYSIWYG migrator when there are non-li elements inside lists.
📌 Related Issues
Testing
<p>Vivamus rhoncus pretium neque et posuere:<ul>\n<li>Suspendisse gravida justo nec ornare rhoncus.</li>\n<li>Morbi venenatis metus augue.</li>\n</ul></p>bin/rails decidim:upgrade:migrate_wysiwyg_contentand see how it's properly converted