Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork428
Don't add the slug of the space in some links#12590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The fix and the code is 💯
I have some improvements in the rspecs.
Also, as I mentioned in#11176, we should change some specs so we would have detected this before:
diff --git a/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rb b/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rbindex 3f5ae0af02..c75166c6ea 100644--- a/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rb+++ b/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rb@@ -44,13 +44,13 @@ module Decidim describe "#show" do subject { described_class.new(participatory_process).show }- it { is_expected.to start_with("/admin/participatory_processes/my-process") }+ it { is_expected.to eq("/admin/participatory_processes/my-process") } end describe "#edit" do subject { described_class.new(participatory_process).edit }- it { is_expected.to start_with("/admin/participatory_processes/my-process/edit") }+ it { is_expected.to eq("/admin/participatory_processes/my-process/edit") } end end
Can you apply this change and also check out my suggestions, please? Thanks
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rbShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
decidim-core/lib/decidim/core/test/shared_examples/resource_locator_presener_examples.rb FixedShow fixedHide fixed
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍🏽
* Don't add the slug of the space in some links* RUnning linters* Add space tests* Add Debug info* Fix debugger* Fix failing specs* Fixing suite* remove the debugger* Apply suggestions from code reviewCo-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>* Extract reusable example* Rename file* Fix initiatives pipeline---------Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
🎩 What? Why?
This PR makes sure there are no URL that is displaying the participatory space slug as query string.
📌 Related Issues
Link your PR to an issue
participatory_process_slug
get parameter added in some links #11176Testing
<participatory_space>_slug
argument.