- Notifications
You must be signed in to change notification settings - Fork413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Don't add the slug of the space in some links#12590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
andreslucena requested changesMar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The fix and the code is 💯
I have some improvements in the rspecs.
Also, as I mentioned in#11176, we should change some specs so we would have detected this before:
diff --git a/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rb b/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rbindex 3f5ae0af02..c75166c6ea 100644--- a/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rb+++ b/decidim-core/spec/presenters/decidim/resource_locator_presenter_spec.rb@@ -44,13 +44,13 @@ module Decidim describe "#show" do subject { described_class.new(participatory_process).show }- it { is_expected.to start_with("/admin/participatory_processes/my-process") }+ it { is_expected.to eq("/admin/participatory_processes/my-process") } end describe "#edit" do subject { described_class.new(participatory_process).edit }- it { is_expected.to start_with("/admin/participatory_processes/my-process/edit") }+ it { is_expected.to eq("/admin/participatory_processes/my-process/edit") } end end
Can you apply this change and also check out my suggestions, please? Thanks
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rb OutdatedShow resolvedHide resolved
decidim-assemblies/spec/presenters/decidim/resource_locator_presenter_spec.rbShow resolvedHide resolved
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
decidim-core/lib/decidim/core/test/shared_examples/resource_locator_presener_examples.rb FixedShow fixedHide fixed
andreslucena approved these changesMar 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍🏽
This was referencedApr 25, 2024
andreslucena added a commit that referenced this pull requestMay 9, 2024
* Don't add the slug of the space in some links* RUnning linters* Add space tests* Add Debug info* Fix debugger* Fix failing specs* Fixing suite* remove the debugger* Apply suggestions from code reviewCo-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>* Extract reusable example* Rename file* Fix initiatives pipeline---------Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR makes sure there are no URL that is displaying the participatory space slug as query string.
📌 Related Issues
Link your PR to an issue
participatory_process_slugget parameter added in some links #11176Testing
<participatory_space>_slugargument.