Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Remove unecessary domain *.jsdelivr.net from CSP connect-src directive#12519

Merged
alecslupu merged 1 commit intodevelopfromfix/csp-jsdelivr-remove
Feb 26, 2024

Conversation

andreslucena
Copy link
Member

🎩 What? Why?

Since the migration from picmo to emojimart (see#12243) we don't need the jsdelivr CDN for the emojis datasets, asin our configuration of emojimart we already bundle all the emojis

📌 Related Issues

Testing

  • Sign in as a user in a private browsing session
  • Go to add a comment and add an emoji
  • See that everything loads and you don't have any error in your web development tools console.

♥️ Thank you!

@andreslucenaandreslucena added team: security module: core type: fixPRs that implement a fix for a bug labelsFeb 22, 2024
Copy link
Contributor

@alecslupualecslupu left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

I have remembered thiscomment from#10700.

@alecslupualecslupu added the no-backportPull Requests that should not be backported labelFeb 26, 2024
@alecslupu
Copy link
Contributor

I have added theno-backport label, as this is a fix targeting 0.29.

@alecslupualecslupu merged commit3edcdf5 intodevelopFeb 26, 2024
@alecslupualecslupu deleted the fix/csp-jsdelivr-remove branchFebruary 26, 2024 10:46
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@alecslupualecslupualecslupu approved these changes

@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

Assignees

@alecslupualecslupu

Labels
module: coreno-backportPull Requests that should not be backportedteam: securitytype: fixPRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@andreslucena@alecslupu

[8]ページ先頭

©2009-2025 Movatter.jp