- Notifications
You must be signed in to change notification settings - Fork413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Change the selected column in budgets' projects#12254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This pull request does not contain a valid label. Please add one of the following labels:['type: feature', 'type: change', 'type: fix', 'type: removal', 'target: developer-experience', 'type: internal']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🎩 What? Why?
Related to#12246, we're using a cross icon ("X") to show that a project wasn't selected in
decidim-budgets
. IMO this isn't clear, so I've asked to@carolromero if we can change this, and she asked to have the "yes/no" words to show if a project was selected (or not). This PR implements that.Testing
📷 Screenshots
Before
After