- Notifications
You must be signed in to change notification settings - Fork413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Refactor of events specs#12063
Refactor of events specs#12063
Conversation
…s to each modified file
I found "a couple" more files to make this change 😅 (I've moved it to the original issue#11567) |
This comment was marked as resolved.
This comment was marked as resolved.
@greenwoodt Please merge with the latest develop, the pipeline issue should be fixed. |
Thanks Alex |
@greenwoodt I marked the PR as draft so i would not approve and merge by mistake :D |
@greenwoodt please check out the linting errors 🙏🏽 |
Thanks! Will sort these before separating into part 2. |
Was the plan! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only one line that I think we can remove, and we're ready to merge 🚀
...itiatives/spec/cells/decidim/initiatives/content_blocks/highlighted_initiatives_cell_spec.rb OutdatedShow resolvedHide resolved
…cks/highlighted_initiatives_cell_spec.rbCo-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
Thanks Andres. I've commited the change and should be ready for review! |
🎩 What? Why?
Refactoring of event_specs in the amendable folder within decidim-core.
📌 Related Issues
Testing
Run the rspec command on the following pages adjusted in this PR to see passed results.
📷 Screenshots