Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(common): escape replaced value#770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
blastZ wants to merge1 commit intodebug-js:master
base:master
Choose a base branch
Loading
fromblastZ:patch-1

Conversation

blastZ
Copy link

Something like thislog('I like %O', { name: '%sugar%' }); will cause output incorrect.

Something like this `log('I like %O', { name: '%sugar%' });` will cause output incorrect.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 87.739% when pullingd687542 on blastZ:patch-1 into80ef62a on visionmedia:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 87.739% when pullingd687542 on blastZ:patch-1 into80ef62a on visionmedia:master.

@Qix-
Copy link
Member

Qix- commentedJul 2, 2020

Can you add tests for this, please? I'm not sure which sorts of things this fixes.

@blastZ
Copy link
Author

Can you add tests for this, please? I'm not sure which sorts of things this fixes.

The default formatters will replace%o and%O, so when arguments go to thelog function,util.format will get arguments like this["...'%sugar%'... }", '...']. So if you don't escape the% in the value,util.format will replace%s with the next argument. That's why issue#766 happend.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@blastZ@coveralls@Qix-
[8]ページ先頭
©2009-2025 Movatter.jp