- Notifications
You must be signed in to change notification settings - Fork3.8k
Create gaussian_discriminant_analysis.py#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -0,0 +1,45 @@ | |||
| import numpy as np | |||
| import pandas as pd | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It seems that you did not use pandas package in your code. So I think you could remove this line.
WuZhuoran commentedJul 11, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Could you please create unit test for this? Maybe you can refersklearn-test for details. |
ddbourgin commentedJul 13, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi@Christakou - thanks for the submission! A few general comments:
You can see the general contribution guidelineshere. Let me know if you have questions ! |
A framework for building general discriminant analysis models, currently implemented quadratic discriminant analysis, will later add support for linear discriminant analysis too.