Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Create gaussian_discriminant_analysis.py#19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Christakou wants to merge1 commit intoddbourgin:master
base:master
Choose a base branch
Loading
fromChristakou:master
Open

Create gaussian_discriminant_analysis.py#19

Christakou wants to merge1 commit intoddbourgin:masterfromChristakou:master

Conversation

@Christakou
Copy link

A framework for building general discriminant analysis models, currently implemented quadratic discriminant analysis, will later add support for linear discriminant analysis too.

@@ -0,0 +1,45 @@
import numpy as np
import pandas as pd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It seems that you did not use pandas package in your code. So I think you could remove this line.

ddbourgin reacted with thumbs up emoji
@WuZhuoran
Copy link
Contributor

WuZhuoran commentedJul 11, 2019
edited
Loading

Could you please create unit test for this?

Maybe you can refersklearn-test for details.

@ddbourgin
Copy link
Owner

ddbourgin commentedJul 13, 2019
edited
Loading

Hi@Christakou - thanks for the submission! A few general comments:

  1. I notice your code relies on the pandas library. In order to be consistent with the rest of the codebase, you should modify the model to expect numpy arrays instead - no pandas allowed :)
  2. In order to demonstrate your code is sound, please include unit tests against an existing implementation of the model. sklearn'sDiscriminantAnalysis module looks like it might be relevant here.
  3. Please include brief documentation in theNumPy style for the public methods in your model.
  4. Style: as much as possible, try to followpep8 style conventions (e.g., camel_case for method, function, and variable names) to ensure readability. You can autoformat your code with theonline Black formatter

You can see the general contribution guidelineshere. Let me know if you have questions !

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@WuZhuoranWuZhuoranWuZhuoran left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Christakou@WuZhuoran@ddbourgin

[8]ページ先頭

©2009-2025 Movatter.jp