- Notifications
You must be signed in to change notification settings - Fork58
Please pull build improvements (and one code fix) from master#22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
kevin-dot-pyle wants to merge14 commits intodavidmalcolm:masterChoose a base branch fromkevin-dot-pyle:master
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Ensure that 'make install' works even if a file named 'install' exists.
Ensure that 'make install' works even if a file named 'install' exists.
Set PLUGIN_NAME from $PYTHON so that multi-Python builds do not collide.
This allows compiling a gcc-python-plugin to run in the context of across-compiler. Using the cross-compiler to build gcc-python-pluginwould produce a plugin that cannot be loaded on the host system.
Replace "cp && sed -i" with "sed >", so that the file is written withthe desired values on the first pass. Using a single sed reduces thenumber of processes and the number of complete file rewrites.
Use $(MAKE) to run the same make even when it is not named 'make' or isnot first on the path. Use -C for simplicity, since the Makefilealready relies on GNU make extensions.
When GNU make is given the rule: a b: $(DEPS) commandThen for each target that needs an update, command will run. If asingle run of command generates all the targets, then multiple runs areat best wasteful and at worst counterproductive if concurrent runs cancorrupt each other's output.
Change generation of print-gcc-version to preprocess, but not compile, adummy source file containing the macro GCC_VERSION, then scan theresulting output to find the numeric value of the macro. This lets thecompiler do the work of expanding the expression, but avoids running atest program. This is necessary for cross-compiler support, sincecross-compiled test outputs cannot be run locally.Store the output in autogenerated-gcc-version, since it is not arunnable program.
Rules in gcc-c-api assume the available ofautogenerated-EXTRA_CFLAGS.txt, so ensure it is generated beforerecursing into gcc-c-api, even in highly parallel workloads.
Generate to a temporary name, so that a failure in the script does notleave behind an up-to-date incomplete file. If the script exitssuccessfully, then rename the file to its proper name.
Use $(filter-out) to eliminate autogenerated-casts.c from the generalrecipe, so that make does not warn when it encounters a specific recipefor autogenerated-casts.c.
Add a convenience function that knows not to quote the keyword NULL.
Instead of passing the contents of autogenerated-EXTRA_CFLAGS.txt on thegcc command line, read it in and use it to decide whether to run gcc org++. This also produces a cleaner failure mode ifautogenerated-EXTRA_CFLAGS.txt has an unexpected value.
Rename GCC_VERSION to TARGET_GCC_VERSION in source files. Add a commandline preprocessor definition setting TARGET_GCC_VERSION to the value ofthe file autogenerated-gcc-version, which contains the effectiveGCC_VERSION of TARGET_GCC.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request covers various build system improvements and one minor bug fix in the generated C code.
Build system:
Generated code bug fix: