- Notifications
You must be signed in to change notification settings - Fork8
Remove README.md as packaged data in the wheel#16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
TheLonelyGhost wants to merge1 commit intodaveoncode:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Remove README.md as packaged data in the wheel#16
TheLonelyGhost wants to merge1 commit intodaveoncode:masterfromTheLonelyGhost:feature/readme-is-not-necessary-wheel-data
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
README.md is not needed here except for reading to provide the`long_description` attribute in `setup.py`, which is then used onlywhen uploading to pypi. It seems we can safely remove it from themanifest while retaining it in git.Normally the `data` published here is for non-python files necessaryfor the program to function (e.g., i18n translations).
codecovbot commentedJun 15, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #16 +/- ##========================================= Coverage 100.00% 100.00% ========================================= Files 48 48 Lines 2621 2621 ========================================= Hits 2621 2621 Continue to review full report at Codecov.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md is not needed here except for reading to provide the
long_descriptionattribute insetup.py, which is then used onlywhen uploading to pypi. It seems we can safely remove it from the
manifest while retaining it in git.
Normally the
datapublished here is for non-python files necessaryfor the program to function (e.g., i18n translations).