- Notifications
You must be signed in to change notification settings - Fork126
Add documentation for proxy support#680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds comprehensive documentation and examples for proxy support in the Databricks SQL Connector. The documentation explains how to configure and use proxy servers with different authentication methods.
- Added detailed proxy documentation covering configuration, authentication methods, and troubleshooting
- Created example script demonstrating proxy authentication with basic auth and Kerberos/Negotiate
- Updated README files to highlight the new proxy support capabilities
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/proxy.md | Complete proxy documentation including configuration, authentication methods, and troubleshooting |
| examples/proxy_authentication.py | Example script demonstrating different proxy authentication methods |
| examples/README.md | Added entry for the new proxy authentication example |
| README.md | Added brief mention of proxy support with references to documentation |
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
Uh oh!
There was an error while loading.Please reload this page.
jprakash-db left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some Nits. Overall LGTM. Thanks for making a very detailed README and examples file. This makes onboarding very easy
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
87fed36 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What type of PR is this?
Description
Add documentation for proxy support
How is this tested?
Related Tickets & Documents