Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PECOBLR-727] Add kerberos support for proxy auth#675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vikrantpuppala merged 17 commits intomainfromkerberos-proxy-auth2
Aug 18, 2025

Conversation

@vikrantpuppala
Copy link
Contributor

@vikrantpuppalavikrantpuppala commentedAug 14, 2025•
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

This PR adds Kerberos/SPNEGO authentication support for proxy authentication by consolidating proxy handling logic and introducing a new authentication method system.

Consolidates proxy detection and authentication logic into a shared utility module
Replaces specific proxy credential parameters with a generic proxy_auth_method parameter
Implements Kerberos/SPNEGO authentication support using the requests-kerberos library

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>

This comment was marked as outdated.

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds Kerberos/SPNEGO authentication support for proxy authentication by consolidating proxy handling logic and introducing a new authentication method system.

  • Consolidates proxy detection and authentication logic into a shared utility module
  • Replaces specific proxy credential parameters with a genericproxy_auth_method parameter
  • Implements Kerberos/SPNEGO authentication support using therequests-kerberos library

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
FileDescription
src/databricks/sql/common/http_utils.pyNew utility module containing shared proxy detection and authentication logic with support for basic and Kerberos authentication methods
src/databricks/sql/common/unified_http_client.pyUpdated to use shared proxy utilities and support per-request proxy decisions with dual pool managers
src/databricks/sql/auth/thrift_http_client.pyRefactored to use shared proxy utilities and removed duplicate authentication logic
src/databricks/sql/backend/sea/utils/http_client.pyUpdated to use shared proxy utilities and cleaned up variable names
src/databricks/sql/auth/common.pyReplaced specific proxy credential parameters with genericproxy_auth_method parameter
src/databricks/sql/utils.pyUpdated to pass newproxy_auth_method parameter instead of individual credentials
src/databricks/sql/backend/thrift_backend.pyAdded support for passing proxy authentication method to transport layer
tests/unit/test_thrift_backend.pyUpdated test to use new shared utility function
tests/unit/test_telemetry.pyFixed method name references to match renamed methods
pyproject.tomlAdded optionalrequests-kerberos dependency for Kerberos authentication support

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
Copy link
Contributor

@jprakash-dbjprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for making the changes

Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
@vikrantpuppalavikrantpuppala merged commit8e97878 intomainAug 18, 2025
24 checks passed
headers:Optional[Dict[str,str]]=None,
**kwargs,
)->Generator[urllib3.HTTPResponse,None,None]:
)->Generator[urllib3.BaseHTTPResponse,None,None]:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Here urllib3 has no BaseHTTPResponse this class is in urllib3.response

AlexPuletti reacted with thumbs up emojiAlexPuletti reacted with eyes emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@jprakash-dbjprakash-dbjprakash-db approved these changes

+1 more reviewer

@CarlosW1998CarlosW1998CarlosW1998 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vikrantpuppala@CarlosW1998@jprakash-db
[8]ページ先頭
©2009-2025 Movatter.jp