- Notifications
You must be signed in to change notification settings - Fork126
query tags integration#663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
query tags integration#663
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
d61e96a tocf7df8dCompareUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
samikshya-db left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
a minor nit, otherwise LGTM. Thanks for making the change
Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>
bcab1df intodatabricks:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
What type of PR is this?
Description
This PR addsQuery Tags support to the Python SQL Connector. Query Tags allow users to attach key-value pairs to SQL executions that appear in the
system.query.historytable.Changes Made:
Created Example File (
examples/query_tags_example.py):Enhanced Integration Test (
tests/e2e/test_driver.py):test_ssp_passthrough()to include Query Tags in session configurationEnhanced Unit Tests (
tests/unit/test_session.py):test_configuration_passthrough()test to verify query tags are properly passed through to the thrift backendtest_session_management()to include query tags in session configuration to ensure query tags work correctly in SEA backendImplementation Details:
Added Query Tags Support in SEA flow (
src/databricks/sql/backend/sea/utils/constants.py):"QUERY_TAGS": ""toALLOWED_SESSION_CONF_TO_DEFAULT_VALUES_MAPto enable query tags support in the SEA (Statement Execution API) backend flowUsage example:
How is this tested?
Testing Details:
Unit Tests:
test_configuration_passthrough()- Verifies Query Tags flow in thrift modetest_session_management()- Verifies Query Tags flow in SEA modeE2E Tests:
test_ssp_passthrough()to include Query Tags in both thirft and SEA modesManual Testing:
examples/query_tags_example.pywith real backend connectionRelated Tickets & Documents