Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

SEA: Reduce network calls for synchronous commands#633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
varun-edachali-dbx merged 8 commits intosea-migrationfromsea-optimise-success
Jul 19, 2025

Conversation

@varun-edachali-dbx
Copy link
Contributor

What type of PR is this?

  • Refactor

Description

Inexecute_command we first send the execute request to the server, following which, if the request is synchronous, we poll for the request state until it is no longer in the pending state. Following this, we make an additionalGET request to the server to get the final request information. There are two areas of improvement:

  • if the request is small and completes execution (i.e., reaches the SUCCEEDED state) within thewait_timeout, then we need not poll for completion or make anotherGET request to the server. We can immediately construct ourResultSet with the provided response.
  • While we poll for the request state, if the state reaches SUCCEEDED then the response is accompanied by the response data that we need to construct theResultSet. We need not make anotherGET request to the server after we are done polling and can instead utilise the last response provided.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

N/A

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Copy link
Contributor

@jayantsing-dbjayantsing-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some questions inline.

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@varun-edachali-dbxvarun-edachali-dbx merged commit8fbca9d intosea-migrationJul 19, 2025
23 checks passed
@varun-edachali-dbxvarun-edachali-dbx mentioned this pull requestJul 22, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jayantsing-dbjayantsing-dbjayantsing-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@varun-edachali-dbx@jayantsing-db

[8]ページ先頭

©2009-2025 Movatter.jp