- Notifications
You must be signed in to change notification settings - Fork126
SEA: Reduce network calls for synchronous commands#633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some questions inline.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
8fbca9d intosea-migrationUh oh!
There was an error while loading.Please reload this page.
What type of PR is this?
Description
In
execute_commandwe first send the execute request to the server, following which, if the request is synchronous, we poll for the request state until it is no longer in the pending state. Following this, we make an additionalGETrequest to the server to get the final request information. There are two areas of improvement:wait_timeout, then we need not poll for completion or make anotherGETrequest to the server. We can immediately construct ourResultSetwith the provided response.ResultSet. We need not make anotherGETrequest to the server after we are done polling and can instead utilise the last response provided.How is this tested?
Related Tickets & Documents
N/A