Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add optional telemetry support to the python connector#628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
saishreeeee merged 264 commits intomainfromtelemetry
Jul 10, 2025

Conversation

@saishreeeee
Copy link
Contributor

@saishreeeeesaishreeeee commentedJul 7, 2025•
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Initial telemetry logs, failure logs, latency logs via telemetry

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Design doc
PECOBLR-585

dbaxaand others added30 commitsAugust 17, 2022 14:02
* Test with multiple python versions.* Update pyarrow to version 9.0.0 to address issue in relation to python 3.10 & a specific version of numpy being pulled in by pyarrow.Closes#26 Signed-off-by: David Black <dblack@atlassian.com>
* Update changelog and bump to v2.0.4* Specifically thank@dbaxa for this change.Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
* Add test: cursors are closed when connection closesSigned-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>my [OAuth PR](https://github.com/databricks/databricks-sql-python/runs/8005844758?check_suite_focus=true) is blocked due to dco validation (following error):<img width="1202" alt="Screen Shot 2022-08-25 at 12 05 40 PM" src="https://user-images.githubusercontent.com/22279672/186747897-c9d57586-366f-41f9-aa66-609f2bf3911f.png">We should try to avoid running dco for internal databricks employees:I am trying to relax the validation based on this guideline:https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-membersand here:https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>this is undo of#42 till we figure out how to fix dco
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
This PR:* Adds the foundation for OAuth against Databricks account on AWS with BYOIDP.* It copies one internal module that Steve Weis@sweisdb wrote for Databricks CLI (oauth.py). Once ecosystem-dev team (Serge, Pieter) build a python sdk core we will move this code to their repo as a dependency. * the PR provides authenticators with visitor pattern format for stamping auth-token which later is intended to be moved to the repo owned by Serge@nfx and and Pieter@pietern
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Bump to v2.1.0 and update changelogSigned-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Mohit Singla <mohit.singla@databricks.com>Co-authored-by: Moe Derakhshani <moe.derakhshani@databricks.com>
* Refactor so we can unit test `inject_parameters`* Add unit tests for inject_parameters* Remove inaccurate comment. Per#51, spark sql does not support escaping a single quote with a second single quote.*Closes#51 and adds unit tests plus the integration test provided in#56Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>Co-authored-by: Courtney Holcomb (@courtneyholcomb)Co-authored-by:@mcannamela
Addresseshttps://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13949Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Add none check on _oauth_persistence in DatabricksOAuthProvider to avoid app crash when _oauth_persistence is None.Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
* Support custom oauth client id and rediret port rangePySQL is used by other tools/CLIs which have own oauth client id,we need to expose oauth_client_id and oauth_redirect_port_rangeas the connection parameters to support this customization.Signed-off-by: Jacky Hu <jacky.hu@databricks.com>* Change oauth redirect port range to portSigned-off-by: Jacky Hu <jacky.hu@databricks.com>* Fix type check issueSigned-off-by: Jacky Hu <jacky.hu@databricks.com>Signed-off-by: Jacky Hu <jacky.hu@databricks.com>
Signed-off-by: Jacky Hu <jacky.hu@databricks.com>Signed-off-by: Jesse <jesse.whitehouse@databricks.com>
Follow up to#67 and#64 * Regenerate TCLIService using latest TCLIService.thrift from DBR (#64)* SI: Implement GET, PUT, and REMOVE (#67)* Re-lock dependencies after merging `main`Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Since the package is under databricks namespace. pip install this package will cause issue importing other packages under the same namespace like automl and feature store. Adding pkgutil style to resolve the issue.Signed-off-by: lu-wang-dl <lu.wang@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link
Contributor

@jprakash-dbjprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for making the changes

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@saishreeeeesaishreeeee merged commit9c34acd intomainJul 10, 2025
22 of 23 checks passed
@saishreeeeesaishreeeee deleted the telemetry branchAugust 1, 2025 08:12
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vikrantpuppalavikrantpuppalavikrantpuppala approved these changes

@jprakash-dbjprakash-dbjprakash-db approved these changes

Assignees

@saishreeeeesaishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

43 participants

@saishreeeee@vikrantpuppala@jprakash-db@dbaxa@moderakh@mohitsingla-db@jackyhu-db@lu-wang-dl@shea-parkes@yunbodeng-db@andrefurlan-db@mattdeekay@sebbegg@itsdani@bkyryliuk@WilliamGentry@dbarrundia-tiger@jacobus-herman@nithinkdb@unj1m@martinitus@Falydoor@pietern@NodeJSmith@benc-db@TimTheinAtTabs@mkazia-db@kravets-levko@aholyoke@wyattscarpenter@amir-haroun@dhirschfeld@susodapop@m1n0@Hodnebo@kfollesdal@shivam2680@arredond@newwingbird@samikshya-db@madhav-db@jayantsing-db
[8]ページ先頭
©2009-2025 Movatter.jp