Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix potential resource leak inCloudFetchQueue#624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
varun-edachali-dbx merged 5 commits intomainfromfix-download-leak
Jul 11, 2025

Conversation

@varun-edachali-dbx
Copy link
Contributor

@varun-edachali-dbxvarun-edachali-dbx commentedJul 4, 2025•
edited
Loading

What type of PR is this?

  • Bug Fix

Description

TheResultFileDownloadManager in theCloudFetchQueue is not shut down alongside theResultSet.

TheResultFileDownloadManager on being requested for a file ensures that the "download queue is always full", i.e. it adds uptomax_download_threads Futures into_download_tasks. In caseResultSet.close() is invoked after this,_shutdown_manager (defined forResultFileDownloadManager) is NOT called, so these Futures keep executing in the background and the files keep being downloaded.

We define aclose for theCloudFetchQueue that invokes_shutdown_manager.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

N/A

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
…gardless of server side stateSigned-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Copy link
Contributor

@samikshya-dbsamikshya-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch! Thanks for this 🚢

varun-edachali-dbx reacted with heart emoji
Copy link
Contributor

@jprakash-dbjprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, Thanks for making the changes

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@varun-edachali-dbxvarun-edachali-dbx merged commit576eafc intomainJul 11, 2025
23 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@samikshya-dbsamikshya-dbsamikshya-db approved these changes

@jayantsing-dbjayantsing-dbjayantsing-db approved these changes

@jprakash-dbjprakash-dbjprakash-db approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@varun-edachali-dbx@samikshya-db@jayantsing-db@jprakash-db
[8]ページ先頭
©2009-2025 Movatter.jp