databricks/databricks-sql-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork126
Star210

Connection errors to unauthenticated telemetry endpoint#619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

saishreeeee merged 273 commits intomainfromtelemetry-unauth

Jul 22, 2025

Merged

Connection errors to unauthenticated telemetry endpoint#619

saishreeeee merged 273 commits intomainfromtelemetry-unauth

Jul 22, 2025

Conversation

Copy link

Contributor

saishreeeee commentedJun 27, 2025•
edited
Loading

What type of PR is this?

Refactor
Feature
Bug Fix
Other

Description

Send error logs to the unauthenticated telemetry endpoint in case of connection/authentication errors (before TelemetryClient initialization)

How is this tested?

Unit tests
E2E Tests

Manually
Tried to establish a connection with an invalid access token

  === Request Details ===  URL: https://e2-dogfood.staging.cloud.databricks.com/telemetry-unauth    Headers:    Accept: application/json    Content-Type: application/json    Request Body Summary:    uploadTime: 1751006386604    items: 0 items    protoLogs: 1 logs    === Proto Logs Details ===    Proto Log #1:  {    "frontend_log_event_id": "15cd988b-55bc-4a97-9e0b-05f6981a8487",    "context": {      "client_context": {        "timestamp_millis": 1751006386604,        "user_agent": "PyDatabricksSqlConnector/4.0.5"      }    },    "entry": {      "sql_driver_log": {        "system_configuration": {          "driver_version": "4.0.5",          "os_name": "Darwin",          "os_version": "24.5.0",          "os_arch": "arm64",          "runtime_name": "Python 3.11.13",          "runtime_version": "3.11.13",          "runtime_vendor": "CPython",          "driver_name": "Databricks SQL Python Connector",          "char_set_encoding": "utf-8",          "locale_name": "en_US"        },        "driver_connection_params": {          "http_path": <HTTP_PATH>,          "mode": "THRIFT",          "host_info": {            "host_url": <SERVER_HOSTNAME>,            "port": 443          }        },        "error_info": {          "error_name": "ConnectionError",          "stack_trace": "Failed to establish connection: Error during request to server: : Invalid access token.. "        }      }    }  }    === Response Details ===  Status Code: 200    Response Body:  {    "errors": [],    "numSuccess": 0,    "numProtoSuccess": 1,    "numRealtimeSuccess": 0  }

Related Tickets & Documents

PECOBLR-636

moderakhand others added30 commits

August 25, 2022 12:18

dco tunning

cf3130e

Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>

dco tunning

4387f93

Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>

Merge pull request#43from moderakh/dco-tunning

285e516

Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>this is undo of#42 till we figure out how to fix dco

Github workflows: run checks on pull requests from forks (#47)

ea0f076

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

OAuth implementation (#15)

616a5c8

This PR:* Adds the foundation for OAuth against Databricks account on AWS with BYOIDP.* It copies one internal module that Steve Weis@sweisdb wrote for Databricks CLI (oauth.py). Once ecosystem-dev team (Serge, Pieter) build a python sdk core we will move this code to their repo as a dependency. * the PR provides authenticators with visitor pattern format for stamping auth-token which later is intended to be moved to the repo owned by Serge@nfx and and Pieter@pietern

Automate deploys to Pypi (#48)

e39d294

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

[PECO-205] Add functional examples (#52)

1ea2fe0

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Bump version to 2.1.0 (#54)

3638fa2

Bump to v2.1.0 and update changelogSigned-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

[SC-110400] Enabling compression in Python SQL Connector (#49)

1a4cf4b

Signed-off-by: Mohit Singla <mohit.singla@databricks.com>Co-authored-by: Moe Derakhshani <moe.derakhshani@databricks.com>

Add tests for parameter sanitisation / escaping (#46)

8d6d47f

* Refactor so we can unit test `inject_parameters`* Add unit tests for inject_parameters* Remove inaccurate comment. Per#51, spark sql does not support escaping a single quote with a second single quote.*Closes#51 and adds unit tests plus the integration test provided in#56Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>Co-authored-by: Courtney Holcomb (@courtneyholcomb)Co-authored-by:@mcannamela

Bump thrift dependency to 0.16.0 (#65)

3d3c692

Addresseshttps://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13949Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Bump version to 2.2.0 (#66)

5cbfcac

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Support Python 3.11 (#60)

c6e573c

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Bump version to 2.2.1 (#70)

7c53b76

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Add none check on _oauth_persistence in DatabricksOAuthProvider (#71)

4f221b3

Add none check on _oauth_persistence in DatabricksOAuthProvider to avoid app crash when _oauth_persistence is None.Signed-off-by: Jacky Hu <jacky.hu@databricks.com>

Support custom oauth client id and redirect port (#75)

cfa38a1

* Support custom oauth client id and rediret port rangePySQL is used by other tools/CLIs which have own oauth client id,we need to expose oauth_client_id and oauth_redirect_port_rangeas the connection parameters to support this customization.Signed-off-by: Jacky Hu <jacky.hu@databricks.com>* Change oauth redirect port range to portSigned-off-by: Jacky Hu <jacky.hu@databricks.com>* Fix type check issueSigned-off-by: Jacky Hu <jacky.hu@databricks.com>Signed-off-by: Jacky Hu <jacky.hu@databricks.com>

Bump version to 2.2.2 (#76)

2f2a761

Signed-off-by: Jacky Hu <jacky.hu@databricks.com>Signed-off-by: Jesse <jesse.whitehouse@databricks.com>

Merge staging ingestion into main (#78)

def5e0e

Follow up to#67 and#64 * Regenerate TCLIService using latest TCLIService.thrift from DBR (#64)* SI: Implement GET, PUT, and REMOVE (#67)* Re-lock dependencies after merging `main`Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Bump version to 2.3.0 and update changelog (#80)

3cc9393

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Add pkgutil-style for the package (#84)

aa55a6e

Since the package is under databricks namespace. pip install this package will cause issue importing other packages under the same namespace like automl and feature store. Adding pkgutil style to resolve the issue.Signed-off-by: lu-wang-dl <lu.wang@databricks.com>

Add SQLAlchemy Dialect (#57)

ce158cb

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Bump to version 2.4.0(#89)

0ed7e53

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Fix syntax in examples in root readme. (#92)

9a06d6c

Do this because the environment variable pulls did not have closing quotes on their string literals.

Less strict numpy and pyarrow dependencies (#90)

20e789f

Signed-off-by: Thomas Newton <thomas.w.newton@gmail.com>Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>Co-authored-by: Thomas Newton <thomas.w.newton@gmail.com>

Update example in docstring so query output is valid Spark SQL (#95)

3a60599

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Bump version to 2.4.1 (#96)

e627649

Per the sermver.org spec, updating the projects dependencies is considered a compatible change.https: //semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-apiSigned-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Update CODEOWNERS (#97)

c43eaf8

Add Andre to CODEOWNERS (#98)

b0b6abd

* Add Andre. Signed-off-by: Yunbo Deng <yunbo.deng@databricks.com>Signed-off-by: yunbodeng-db <104732431+yunbodeng-db@users.noreply.github.com>* Revert the change temporarily so I can sign off. Signed-off-by: Yunbo Deng <yunbo.deng@databricks.com>Signed-off-by: yunbodeng-db <104732431+yunbodeng-db@users.noreply.github.com>* Add Andre and sign off. Signed-off-by: Yunbo Deng <yunbo.deng@databricks.com>Signed-off-by: yunbodeng-db <104732431+yunbodeng-db@users.noreply.github.com>* Remove redundant lineSigned-off-by: yunbodeng-db <104732431+yunbodeng-db@users.noreply.github.com>---------Signed-off-by: yunbodeng-db <104732431+yunbodeng-db@users.noreply.github.com>

Add external auth provider + example (#101)

f440791

Signed-off-by: Andre Furlan <andre.furlan@databricks.com>Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>Co-authored-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

Retry on connection timeout (#103)

5f247e5

A lot of the time we see the error `[Errno 110] Connection timed out`. This happens a lot in Azure, particularly. In this PR I make it a retryable error as it is safeSigned-off-by: Andre Furlan <andre.furlan@databricks.com>

saishreeeee had a problem deploying to azure-prod

July 16, 2025 07:50

— with

GitHub Actions Failure

Copy link

github-actionsbot commentedJul 16, 2025

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

error log for auth provider, ThriftDatabricksClient

28bf612

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee temporarily deployed to azure-prod

July 16, 2025 09:51

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedJul 16, 2025

error log for session.open

f307a5f

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod

July 16, 2025 10:25

— with

GitHub Actions Failure

Copy link

github-actionsbot commentedJul 16, 2025

retry tests fix

474bdfc

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee temporarily deployed to azure-prod

July 16, 2025 13:18

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedJul 16, 2025

test connection failure log

0f5ca24

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee temporarily deployed to azure-prod

July 16, 2025 13:26

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedJul 16, 2025

check types fix

ee29b9b

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee temporarily deployed to azure-prod

July 16, 2025 13:35

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedJul 16, 2025

databricks deleted a comment fromgithub-actionsbot

Jul 16, 2025

test

46075f9

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee had a problem deploying to azure-prod

July 17, 2025 04:46

— with

GitHub Actions Failure

Copy link

github-actionsbot commentedJul 17, 2025

saishreeeee temporarily deployed to azure-prod

July 17, 2025 07:45

— with

GitHub Actions Inactive

saishreeeee requested a review fromvikrantpuppala

July 17, 2025 08:24

vikrantpuppala approved these changes

Jul 17, 2025

View reviewed changes

jprakash-db approved these changes

Jul 22, 2025

View reviewed changes

Copy link

Contributor

jprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some Nits . Overall LGTM

tests/unit/test_telemetry.py OutdatedShow resolvedHide resolved

rephrase import

dab5712

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

saishreeeee temporarily deployed to azure-prod

July 22, 2025 12:19

— with

GitHub Actions Inactive

Copy link

github-actionsbot commentedJul 22, 2025

saishreeeee merged commitc6f4a27 intomain

Jul 22, 2025

22 of 23 checks passed

saishreeeee deleted the telemetry-unauth branch

August 1, 2025 08:11

Labels

None yet

42 participants

Movatterモバイル変換

Connection errors to unauthenticated telemetry endpoint#619

Connection errors to unauthenticated telemetry endpoint#619

Uh oh!

Conversation

saishreeeee commentedJun 27, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

What type of PR is this?

Description

How is this tested?

Related Tickets & Documents

Uh oh!

github-actionsbot commentedJul 16, 2025

Uh oh!

github-actionsbot commentedJul 16, 2025

Uh oh!

github-actionsbot commentedJul 16, 2025

Uh oh!

github-actionsbot commentedJul 16, 2025

Uh oh!

github-actionsbot commentedJul 16, 2025

Uh oh!

github-actionsbot commentedJul 16, 2025

Uh oh!

github-actionsbot commentedJul 17, 2025

Uh oh!

jprakash-db left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actionsbot commentedJul 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

42 participants

saishreeeee commentedJun 27, 2025•
edited
Loading