Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Complete Fetch Phase (forINLINE disposition andJSON_ARRAY format)#594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
varun-edachali-dbx merged 228 commits intosea-migrationfromfetch-json-inline
Jul 2, 2025

Conversation

@varun-edachali-dbx
Copy link
Contributor

@varun-edachali-dbxvarun-edachali-dbx commentedJun 11, 2025•
edited
Loading

What type of PR is this?

  • Feature

Description

Complete the Fetch phase of the SEA implementation forINLINE disposition andJSON_ARRAY format. Introduce a newJsonQueue.

Note that this is not yet feature complete, with some known failures in the following domains (for the SEA backend only):

  • retries
  • native, complex params
  • metadata queries

These will be resolved in future PRs.

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually - using the test scripts invoked inexamples/experimental/sea_connector_test.py.
  • N/A

The coverage of the key classes by the unit tests are as below:

ModuleStatementsMissingCoverageNotes
utils.py (JsonQueue class)150100%Completely covered
utils.py (SeaResultSetQueueFactory class)200100%Completely covered
result_set.py (SeaResultSet class)1550100%Completely covered
conversion.py430100%Completely covered

Related Tickets & Documents

Design Doc
PECOBLR-484

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@databricksdatabricks deleted a comment fromgithub-actionsbotJul 1, 2025
@databricksdatabricks deleted a comment fromgithub-actionsbotJul 1, 2025
@databricksdatabricks deleted a comment fromgithub-actionsbotJul 1, 2025
@databricksdatabricks deleted a comment fromgithub-actionsbotJul 1, 2025
@databricksdatabricks deleted a comment fromgithub-actionsbotJul 1, 2025
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link
Contributor

@jayantsing-dbjayantsing-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor comments. Rest LGTM.

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@varun-edachali-dbxvarun-edachali-dbx merged commit70c7dc8 intosea-migrationJul 2, 2025
22 of 23 checks passed
varun-edachali-dbx added a commit that referenced this pull requestJul 22, 2025
@varun-edachali-dbxvarun-edachali-dbx mentioned this pull requestJul 23, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jayantsing-dbjayantsing-dbjayantsing-db approved these changes

@deeksha-dbdeeksha-dbAwaiting requested review from deeksha-db

@samikshya-dbsamikshya-dbAwaiting requested review from samikshya-db

@jprakash-dbjprakash-dbAwaiting requested review from jprakash-db

@jackyhu-dbjackyhu-dbAwaiting requested review from jackyhu-db

@madhav-dbmadhav-dbAwaiting requested review from madhav-db

@gopalldbgopalldbAwaiting requested review from gopalldb

@vikrantpuppalavikrantpuppalaAwaiting requested review from vikrantpuppala

@shivam2680shivam2680Awaiting requested review from shivam2680

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@varun-edachali-dbx@jayantsing-db
[8]ページ先頭
©2009-2025 Movatter.jp