Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

E2E POC for python telemetry for connect logs#581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
saishreeeee merged 269 commits intotelemetryfromPECOBLR-457
Jun 10, 2025

Conversation

@saishreeeee
Copy link
Contributor

@saishreeeeesaishreeeee commentedJun 3, 2025•
edited
Loading

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Added TelemetryClient and TelemetryClientFactory
Added functionality to export initial telemetry logs

How is this tested?

  • Unit tests
    Added unit tests to check the functionality of telemetry client and telemetry client factory
  • E2E Tests
  • Manually
    Ran a query that triggered the export of initital telemetry log, verified that the log was present in the target table
  • N/A

Related Tickets & Documents

PECOBLR-457

@saishreeeeesaishreeeee marked this pull request as draftJune 3, 2025 02:51
@saishreeeeesaishreeeee marked this pull request as ready for reviewJune 3, 2025 05:05
@saishreeeeesaishreeeee self-assigned thisJun 3, 2025
Copy link
Contributor

@vikrantpuppalavikrantpuppala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can we break down this PR further please? let's start with simple connect logs, then error logs and then latency logs

saishreeeee reacted with thumbs up emoji
@saishreeeeesaishreeeee changed the titleE2E POC for python telemetry for connect + latency + error logsE2E POC for python telemetry for connect logsJun 3, 2025
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
…unit tests accordinglySigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
…etry_client does not return a telemetry clientSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
…as constants, added callback function while submitting request to executor, changed del to popSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Copy link
Contributor

@jprakash-dbjprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for making the changes.

@saishreeeeesaishreeeee merged commit9dc7d52 intotelemetryJun 10, 2025
23 checks passed
@saishreeeeesaishreeeee deleted the PECOBLR-457 branchAugust 1, 2025 08:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@jprakash-dbjprakash-dbjprakash-db approved these changes

@deeksha-dbdeeksha-dbAwaiting requested review from deeksha-db

@samikshya-dbsamikshya-dbAwaiting requested review from samikshya-db

@jackyhu-dbjackyhu-dbAwaiting requested review from jackyhu-db

@madhav-dbmadhav-dbAwaiting requested review from madhav-db

@gopalldbgopalldbAwaiting requested review from gopalldb

@jayantsing-dbjayantsing-dbAwaiting requested review from jayantsing-db

@shivam2680shivam2680Awaiting requested review from shivam2680

@vikrantpuppalavikrantpuppalaAwaiting requested review from vikrantpuppala

Assignees

@saishreeeeesaishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

42 participants

@saishreeeee@vikrantpuppala@jprakash-db@moderakh@mohitsingla-db@jackyhu-db@lu-wang-dl@shea-parkes@yunbodeng-db@andrefurlan-db@mattdeekay@sebbegg@itsdani@bkyryliuk@WilliamGentry@dbarrundia-tiger@jacobus-herman@nithinkdb@unj1m@martinitus@Falydoor@pietern@NodeJSmith@benc-db@TimTheinAtTabs@mkazia-db@kravets-levko@aholyoke@wyattscarpenter@amir-haroun@dhirschfeld@susodapop@m1n0@Hodnebo@kfollesdal@shivam2680@arredond@newwingbird@samikshya-db@madhav-db@jayantsing-db
[8]ページ先頭
©2009-2025 Movatter.jp