Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[PECOBLR-201] add variant support#560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
shivam2680 merged 7 commits intomainfromshivam2680/variant
Aug 22, 2025
Merged

Conversation

@shivam2680
Copy link
Contributor

@shivam2680shivam2680 commentedMay 19, 2025•
edited
Loading

Description

This pull request introduces support for detecting and handling VARIANT column types in the Databricks SQL Thrift backend, along with corresponding tests for validation.
updated the_col_to_description and_hive_schema_to_description methods to process metadata for VARIANT types
Added unit and end-to-end tests to ensure proper functionality.

Testing details

End-to-End Tests:

  • Addedtests/e2e/test_variant_types.py to validate VARIANT type detection and data retrieval. Includes tests for creating tables with VARIANT columns, inserting records, and verifying correct type handling and JSON parsing.

Unit Tests:

  • Tests cover scenarios like VARIANT type detection, handling of null or malformed metadata, and fallback behavior for missing Arrow schemas.

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@shivam2680shivam2680 changed the titleadd variant support[PECOBLR-201]. add variant supportMay 19, 2025
@shivam2680shivam2680 changed the title[PECOBLR-201]. add variant support[PECOBLR-201] add variant supportMay 19, 2025
@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

Copy link
Contributor

@jprakash-dbjprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you plz incorporate@pytest.mark.parametrize , I feel a lot of test code duplication can be avoided

@github-actions
Copy link

Thanks for your contribution! To satisfy the DCO policy in ourcontributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@shivam2680
Copy link
ContributorAuthor

Thetest_thrift_backend class inherits fromunittest.TestCase, which is designed for unittest's test discovery and execution model. When you use @pytest.mark.parametrize with a unittest.TestCase class:

  • Pytest creates separate test instances for each parameter set
  • Unittest's test runner doesn't understand these parametrized arguments
  • Result: TypeError: missing required positional arguments

Copy link
Contributor

@jprakash-dbjprakash-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks for making the changes

@jayantsing-dbjayantsing-db self-requested a reviewAugust 22, 2025 07:33
@shivam2680shivam2680 merged commit048fae1 intomainAug 22, 2025
29 of 30 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jayantsing-dbjayantsing-dbjayantsing-db approved these changes

@jprakash-dbjprakash-dbjprakash-db approved these changes

@madhav-dbmadhav-dbAwaiting requested review from madhav-db

@gopalldbgopalldbAwaiting requested review from gopalldb

+1 more reviewer

@Varun0157Varun0157Varun0157 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shivam2680@Varun0157@jayantsing-db@jprakash-db
[8]ページ先頭
©2009-2025 Movatter.jp