Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for python 3.13 & remove various version caps#504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
dbaxa wants to merge4 commits intodatabricks:mainfromdbaxa:main

Conversation

@dbaxa
Copy link
Contributor

@dbaxadbaxa commentedFeb 11, 2025
edited
Loading

Add support for python 3.13 & remove various version caps

Raytray reacted with heart emoji
numpy = [
{version ="^1.16.6",python =">=3.8,<3.11" },
{version ="^1.23.4",python =">=3.11" },
{version =">=1.16.6",python =">=3.8,<3.11" },
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For some reason01e998c#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711 reverted the change made ind690516 to remove the version caps.

* Remove upper caps on numpy and pyarrow versionsSigned-off-by: David Black <dblack@atlassian.com>
Signed-off-by: David Black <dblack@atlassian.com>
Signed-off-by: David Black <dblack@atlassian.com>
Signed-off-by: David Black <dblack@atlassian.com>
@jprakash-db
Copy link
Contributor

@dbaxa Python3.13 testing can be included. As far as relaxing the numpy version we reverted it as it had compatibility issues with pandas -https://pandas.pydata.org/docs/whatsnew/v2.2.2.html#pandas-2-2-2-is-now-compatible-with-numpy-2-0

dhirschfeld added a commit to dhirschfeld/databricks-sql-python that referenced this pull requestFeb 20, 2025
@dbaxa
Copy link
ContributorAuthor

dbaxa commentedFeb 20, 2025
edited
Loading

@jprakash-db can you provide more details about the compatibility issues? In our use case we didn't see any problems with using python 3.13 pandas 2.2.3 & numpy 2.2.3 when using a modified version ofdatabricks-sql-python locally.

As in

One major caveat is that arrays created with numpy 2.0's newStringDtype will convert toobject dtyped arrays upon :class:Series/:class:DataFrame creation. Full support for numpy 2.0's StringDtype is expected to land in pandas 3.0.

doesn't seem like an issue to me becauseStringDtype was introduced in numpy 2.0.0 and people apparently would need to explicitly use the new type (pandas-dev/pandas#58104 (comment) &aws/sagemaker-python-sdk#4882 (comment)).

@dhirschfeld
Copy link
Contributor

Asdatabricks-sql-python doesn't directly importnumpy we shouldn't be specifying it as a dependency here.

In this code base we only rely onpandas functionality, we don't care how pandas implements that functionality under the hood.

Our contract is with the public API ofpandas and we trust thepandas devs to ensure their library works correctly. Ifpandas doesn't work with a modernnumpy it is for them to pinnumpy as it is their dependency.

pandas claims to supportnumpy>=1.26:
https://github.com/pandas-dev/pandas/blob/main/pyproject.toml#L30-L31

...so if that is not the case we should open an issue (or PR) in thepandas repo to apply the pin there.

Packaging bugs occur (all the time!) but if this pin here is to work around a mis-specified dependency thatpandas once had at one time, the cure is worse that the cold. Pinning to an oldnumpy means thatdatabricks-sql-connector can't be used in any modern analytics environment which isn't great for a package designed to support analytics.

samikshya-db reacted with thumbs up emoji

@samikshya-db
Copy link
Contributor

Thanks for raising this :dhirschfeld, this makes sense to me. I am closing this in favour of#510

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rcypher-databricksrcypher-databricksAwaiting requested review from rcypher-databricks

@yunbodeng-dbyunbodeng-dbAwaiting requested review from yunbodeng-db

@andrefurlan-dbandrefurlan-dbAwaiting requested review from andrefurlan-db

@jackyhu-dbjackyhu-dbAwaiting requested review from jackyhu-db

@benc-dbbenc-dbAwaiting requested review from benc-db

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dbaxa@jprakash-db@dhirschfeld@samikshya-db

[8]ページ先頭

©2009-2025 Movatter.jp