- Notifications
You must be signed in to change notification settings - Fork126
Add e2e tests#12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This requires the following repository secrets will be configured on GH:E2E_TEST_HOSTE2E_TEST_HTTP_PATHE2E_TEST_TOKEN
| on:[push] | ||
| jobs: | ||
| run-tests: | ||
| run-unit-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what does unit test mean in this context?
Is this mock unit test without the need for databricks account?
or is it integration test e2e which require databricks account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
unit means no databricks account is required.e2e means databricks account is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm updating the CONTRIBUTING doc with this info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks Jesse.
This reverts commitf7da497.Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>Signed-off-by: Moe Derakhshani <moe.derakhshani@databricks.com>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>
Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
Uh oh!
There was an error while loading.Please reload this page.
Description