Commitebf4ac4

committed

[ES-402013] Check that closing the connection also closes any active cursors.

Signed-off-by: Jesse Whitehouse <jesse@whitehouse.dev>

1 parent9bb2323 commitebf4ac4Copy full SHA for ebf4ac4

File tree

+15

-3

lines changed

+15

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -181,13 +181,14 @@ def close(self) -> None:`
`181`	`181`	`self._close()`
`182`	`182`
`183`	`183`	`def_close(self,close_cursors=True)->None:`
`184`		`-self.thrift_backend.close_session(self._session_handle)`
`185`		`-self.open=False`
`186`		`-`
`187`	`184`	`ifclose_cursors:`
`188`	`185`	`forcursorinself._cursors:`
`189`	`186`	`cursor.close()`
`190`	`187`
	`188`	`+self.thrift_backend.close_session(self._session_handle)`
	`189`	`+self.open=False`
	`190`	`+`
	`191`	`+`
`191`	`192`	`defcommit(self):`
`192`	`193`	`"""No-op because Databricks does not support transactions"""`
`193`	`194`	`pass`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -544,6 +544,17 @@ def test_decimal_not_returned_as_strings_arrow(self):`
`544`	`544`	`decimal_type=arrow_df.field(0).type`
`545`	`545`	`self.assertTrue(pyarrow.types.is_decimal(decimal_type))`
`546`	`546`
	`547`	`+deftest_close_connection_closes_cursors(self):`
	`548`	`+withself.connection()asconn:`
	`549`	`+cursor=conn.cursor()`
	`550`	+cursor.execute('SELECT id, id `id2`, id `id3` FROM RANGE(1000000) order by RANDOM()')
	`551`	`+ars=cursor.active_result_set`
	`552`	`+assertnotbool(ars.has_been_closed_server_side)`
	`553`	`+conn.close()`
	`554`	`+assertbool(ars.has_been_closed_server_side)`
	`555`	`+cursor.close()`
	`556`	`+`
	`557`	`+`
`547`	`558`
`548`	`559`	`# use a RetrySuite to encapsulate these tests which we'll typically want to run together; however keep`
`549`	`560`	`# the 429/503 subsuites separate since they execute under different circumstances.`

Comments

(0)