Commitc71e081

authored

SQLAlchemy: TINYINT types didn't reflect properly (#315)

Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

1 parent4bb3c9e commitc71e081Copy full SHA for c71e081

File tree

+12

-5

lines changed

+12

-5

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,8 @@`
`2`	`2`
`3`	`3`	`#3.1.0 (TBD)`
`4`	`4`
`5`		`-- SQLAlchemy: Added support for table and column comments (thanks@cbornet!)`
	`5`	`+- SQLAlchemy dialect now supports table and column comments (thanks@cbornet!)`
	`6`	`+- Fix: SQLAlchemy dialect now correctly reflects TINYINT types (thanks@TimTheinAtTabs!)`
`6`	`7`	- Fix:`server_hostname` URIs that included`https://` would raise an exception
`7`	`8`	- Other: pinned to`pandas<=2.1` and`urllib3>=1.26` to avoid runtime errors in dbt-databricks (#330)
`8`	`9`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -305,6 +305,7 @@ def get_comment_from_dte_output(dte_output: List[Dict[str, str]]) -> Optional[st`
`305`	`305`	`GET_COLUMNS_TYPE_MAP= {`
`306`	`306`	`"boolean":sqlalchemy.types.Boolean,`
`307`	`307`	`"smallint":sqlalchemy.types.SmallInteger,`
	`308`	`+"tinyint":type_overrides.TINYINT,`
`308`	`309`	`"int":sqlalchemy.types.Integer,`
`309`	`310`	`"bigint":sqlalchemy.types.BigInteger,`
`310`	`311`	`"float":sqlalchemy.types.Float,`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -316,3 +316,7 @@ class TINYINT(sqlalchemy.types.TypeDecorator):`
`316`	`316`
`317`	`317`	`impl=sqlalchemy.types.SmallInteger`
`318`	`318`	`cache_ok=True`
	`319`	`+`
	`320`	`+@compiles(TINYINT,"databricks")`
	`321`	`+defcompile_tinyint(type_,compiler,**kw):`
	`322`	`+return"TINYINT"`

Lines changed: 5 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ def test_numeric_renders_as_decimal_with_precision(self):`
`111`	`111`	`)`
`112`	`112`
`113`	`113`	`deftest_numeric_renders_as_decimal_with_precision_and_scale(self):`
`114`		`-returnself._assert_compiled_value_explicit(`
	`114`	`+self._assert_compiled_value_explicit(`
`115`	`115`	`sqlalchemy.types.Numeric(10,2),"DECIMAL(10, 2)"`
`116`	`116`	`)`
`117`	`117`
`@@ -146,15 +146,16 @@ def test_bare_uppercase_types_compile(self, type_, expected):`
`146`	`146`	`ifisinstance(type_,type(sqlalchemy.types.ARRAY)):`
`147`	`147`	`# ARRAY cannot be initialised without passing an item definition so we test separately`
`148`	`148`	`# I preserve it in the uppercase_type_map for clarity`
`149`		`-returnTrue`
`150`		`-returnself._assert_compiled_value(type_,expected)`
	`149`	`+assertTrue`
	`150`	`+else:`
	`151`	`+self._assert_compiled_value(type_,expected)`
`151`	`152`
`152`	`153`	`deftest_array_string_renders_as_array_of_string(self):`
`153`	`154`	`"""SQLAlchemy's ARRAY type requires an item definition. And their docs indicate that they've only tested`
`154`	`155`	`it with Postgres since that's the only first-class dialect with support for ARRAY.`
`155`	`156`
`156`	`157`	`https://docs.sqlalchemy.org/en/20/core/type_basics.html#sqlalchemy.types.ARRAY`
`157`	`158`	`"""`
`158`		`-returnself._assert_compiled_value_explicit(`
	`159`	`+self._assert_compiled_value_explicit(`
`159`	`160`	`sqlalchemy.types.ARRAY(sqlalchemy.types.String),"ARRAY<STRING>"`
`160`	`161`	`)`

Comments

(0)