Commitb35f0c9

Jesse Whitehouse

committed

First implementation that passes the integration test.

There seems to be two mechanisms where I can hook into the type compilerIn this one, I explicitly set a dialect-specific compilation overwrite.Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>

1 parent96774b1 commitb35f0c9Copy full SHA for b35f0c9

File tree

2 files changed

-0

lines changed

src/databricks/sqlalchemy/dialect
- __init__.py
tests/e2e/sqlalchemy
- test_basic.py

2 files changed

-0

lines changed

`‎src/databricks/sqlalchemy/dialect/init.py‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,12 @@ class TINYINT(types.Integer):`
`74`	`74`	`Details about this type: https://docs.databricks.com/sql/language-manual/data-types/tinyint-type.html`
`75`	`75`	`"""`
`76`	`76`	`__visit_name__="TINYINT"`
	`77`	`+`
	`78`	`+fromsqlalchemy.ext.compilerimportcompiles`
	`79`	`+@compiles(TINYINT,"databricks")`
	`80`	`+defcompile_tinyint_databricks(type_,compiler,**kw):`
	`81`	`+return"TINYINT"`
	`82`	`+`
`77`	`83`	`classDatabricksDialect(default.DefaultDialect):`
`78`	`84`	`"""This dialect implements only those methods required to pass our e2e tests"""`
`79`	`85`

`‎tests/e2e/sqlalchemy/test_basic.py‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`	`fromsqlalchemyimportcreate_engine,select,insert,Column,MetaData,Table`
`5`	`5`	`fromsqlalchemy.ormimportdeclarative_base,Session`
`6`	`6`	`fromsqlalchemy.typesimportSMALLINT,Integer,BOOLEAN,String,DECIMAL,Date`
	`7`	`+fromdatabricks.sqlalchemy.dialectimportTINYINT`
`7`	`8`
`8`	`9`
`9`	`10`	`USER_AGENT_TOKEN="PySQL e2e Tests"`
`@@ -150,6 +151,7 @@ def test_create_insert_drop_table_core(base, db_engine, metadata_obj: MetaData):`
`150`	`151`	`Column("episodes",Integer),`
`151`	`152`	`Column("some_bool",BOOLEAN),`
`152`	`153`	`Column("dollars",DECIMAL(10,2)),`
	`154`	`+Column("tiny_int",TINYINT)`
`153`	`155`	`)`
`154`	`156`
`155`	`157`	`metadata_obj.create_all()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb35f0c9

File tree

2 files changed

2 files changed

`‎src/databricks/sqlalchemy/dialect/init.py‎`

`‎tests/e2e/sqlalchemy/test_basic.py‎`

0 commit comments

Movatterモバイル変換

File tree

2 files changed

2 files changed

‎src/databricks/sqlalchemy/dialect/__init__.py‎

‎tests/e2e/sqlalchemy/test_basic.py‎

0 commit comments

`‎src/databricks/sqlalchemy/dialect/init.py‎`

`‎tests/e2e/sqlalchemy/test_basic.py‎`