Commit94e67f7

committed

small fixes

Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>

1 parent12ff47d commit94e67f7Copy full SHA for 94e67f7

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -429,7 +429,7 @@ def close(session_id_hex):`
`429`	`429`	`)`
`430`	`430`	`try:`
`431`	`431`	`TelemetryClientFactory._executor.shutdown(wait=True)`
`432`		`-TelemetryHttpClient.get_instance().close()`
	`432`	`+TelemetryHttpClient.close()`
`433`	`433`	`exceptExceptionase:`
`434`	`434`	`logger.debug("Failed to shutdown thread pool executor: %s",e)`
`435`	`435`	`TelemetryClientFactory._executor=None`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ def get_client(self, session_id, num_retries=3):`
`61`	`61`	`)`
`62`	`62`	`adapter=client._http_client.session.adapters.get("https://")`
`63`	`63`	`adapter.max_retries=retry_policy`
`64`		`-returnclient,adapter`
	`64`	`+returnclient`
`65`	`65`
`66`	`66`	`@pytest.mark.parametrize(`
`67`	`67`	`"status_code, description",`
`@@ -77,7 +77,7 @@ def test_non_retryable_status_codes_are_not_retried(self, status_code, descripti`
`77`	`77`	`Verifies that terminal error codes (401, 403, 501) and success codes (200) are not retried.`
`78`	`78`	`"""`
`79`	`79`	`# Use the status code in the session ID for easier debugging if it fails`
`80`		`-client,_=self.get_client(f"session-{status_code}")`
	`80`	`+client=self.get_client(f"session-{status_code}")`
`81`	`81`	`mock_responses= [{"status":status_code}]`
`82`	`82`
`83`	`83`	`withpatch(PATCH_TARGET,return_value=create_mock_conn(mock_responses))asmock_get_conn:`
`@@ -94,7 +94,7 @@ def test_exceeds_retry_count_limit(self):`
`94`	`94`	`num_retries=3`
`95`	`95`	`expected_total_calls=num_retries+1`
`96`	`96`	`retry_after=1`
`97`		`-client,_=self.get_client("session-exceed-limit",num_retries=num_retries)`
	`97`	`+client=self.get_client("session-exceed-limit",num_retries=num_retries)`
`98`	`98`	`mock_responses= [{"status":503,"headers": {"Retry-After":str(retry_after)}}, {"status":429}, {"status":502}, {"status":503}]`
`99`	`99`
`100`	`100`	`withpatch(PATCH_TARGET,return_value=create_mock_conn(mock_responses))asmock_get_conn:`

Comments

(0)