Commit9092004

saishreeeee

authored and

varun-edachali-dbx

committed

PECOBLR-86 improve logging on python driver (#556)

* PECOBLR-86 Improve logging for debug levelSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>* PECOBLR-86 Improve logging for debug levelSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>* fixed formatSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>* used lazy loggingSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>* changed debug to error logsSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>* used lazy loggingSigned-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>---------Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>Signed-off-by: varun-edachali-dbx <varun.edachali@databricks.com>

1 parent4148a2c commit9092004Copy full SHA for 9092004

File tree

2 files changed

+26

-0

lines changed

src/databricks/sql
- backend
  - thrift_backend.py
- client.py

2 files changed

+26

-0

lines changed

`‎src/databricks/sql/backend/thrift_backend.py‎`

Lines changed: 17 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,13 @@ def __init__(`
`132`	`132`	`# max_download_threads`
`133`	`133`	`# Number of threads for handling cloud fetch downloads. Defaults to 10`
`134`	`134`
	`135`	`+logger.debug(`
	`136`	`+"ThriftBackend.__init__(server_hostname=%s, port=%s, http_path=%s)",`
	`137`	`+server_hostname,`
	`138`	`+port,`
	`139`	`+http_path,`
	`140`	`+ )`
	`141`	`+`
`135`	`142`	`port=portor443`
`136`	`143`	`ifkwargs.get("_connection_uri"):`
`137`	`144`	`uri=kwargs.get("_connection_uri")`
`@@ -403,6 +410,8 @@ def attempt_request(attempt):`
`403`	`410`
`404`	`411`	`# TODO: don't use exception handling for GOS polling...`
`405`	`412`
	`413`	`+logger.error("ThriftBackend.attempt_request: HTTPError: %s",err)`
	`414`	`+`
`406`	`415`	`gos_name=TCLIServiceClient.GetOperationStatus.__name__`
`407`	`416`	`ifmethod.__name__==gos_name:`
`408`	`417`	`delay_default= (`
`@@ -447,6 +456,7 @@ def attempt_request(attempt):`
`447`	`456`	`else:`
`448`	`457`	`logger.warning(log_string)`
`449`	`458`	`exceptExceptionaserr:`
	`459`	`+logger.error("ThriftBackend.attempt_request: Exception: %s",err)`
`450`	`460`	`error=err`
`451`	`461`	`retry_delay=extract_retry_delay(attempt)`
`452`	`462`	`error_message= (`
`@@ -904,6 +914,12 @@ def execute_command(`
`904`	`914`	`):`
`905`	`915`	`assertsession_handleisnotNone`
`906`	`916`
	`917`	`+logger.debug(`
	`918`	`+"ThriftBackend.execute_command(operation=%s, session_handle=%s)",`
	`919`	`+operation,`
	`920`	`+session_handle,`
	`921`	`+ )`
	`922`	`+`
`907`	`923`	`spark_arrow_types=ttypes.TSparkArrowTypes(`
`908`	`924`	`timestampAsArrow=self._use_arrow_native_timestamps,`
`909`	`925`	`decimalAsArrow=self._use_arrow_native_decimals,`
`@@ -1090,6 +1106,7 @@ def fetch_results(`
`1090`	`1106`	`returnqueue,resp.hasMoreRows`
`1091`	`1107`
`1092`	`1108`	`defclose_command(self,op_handle):`
	`1109`	`+logger.debug("ThriftBackend.close_command(op_handle=%s)",op_handle)`
`1093`	`1110`	`req=ttypes.TCloseOperationReq(operationHandle=op_handle)`
`1094`	`1111`	`resp=self.make_request(self._client.CloseOperation,req)`
`1095`	`1112`	`returnresp.status`

`‎src/databricks/sql/client.py‎`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -216,6 +216,12 @@ def read(self) -> Optional[OAuthToken]:`
`216`	`216`	`# use_cloud_fetch`
`217`	`217`	`# Enable use of cloud fetch to extract large query results in parallel via cloud storage`
`218`	`218`
	`219`	`+logger.debug(`
	`220`	`+"Connection.__init__(server_hostname=%s, http_path=%s)",`
	`221`	`+server_hostname,`
	`222`	`+http_path,`
	`223`	`+ )`
	`224`	`+`
`219`	`225`	`ifaccess_token:`
`220`	`226`	`access_token_kv= {"access_token":access_token}`
`221`	`227`	`kwargs= {kwargs,access_token_kv}`
`@@ -745,6 +751,9 @@ def execute(`
`745`	`751`
`746`	`752`	`:returns self`
`747`	`753`	`"""`
	`754`	`+logger.debug(`
	`755`	`+"Cursor.execute(operation=%s, parameters=%s)",operation,parameters`
	`756`	`+ )`
`748`	`757`
`749`	`758`	`param_approach=self._determine_parameter_approach(parameters)`
`750`	`759`	`ifparam_approach==ParameterApproach.NONE:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit9092004

File tree

2 files changed

2 files changed

`‎src/databricks/sql/backend/thrift_backend.py‎`

`‎src/databricks/sql/client.py‎`

0 commit comments